New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 598386 link

Starred by 1 user
Status: Verified
Owner:
xixuan@chromium.org
Closed: Jun 2016
Cc:
█ fdeng@chromium.org
█ jrbarnette@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocking:
issue 597687



Sign in to add a comment

Fix: The servo being down blocked the rest of DUT repair process.

Project Member Reported by xixuan@chromium.org, Mar 28 2016 
When enabling SSH switch for servo, there exists a chance that tunnel fails to establish, which leads to an exception that can't be catched.

The rest of repair job is stopped therefore, which doesn't make sense.

The repair job's log: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/hosts/chromeos1-row5-rack2-host2/642124-repair/20162403094845/debug/
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2b80c18a812ebbabe740563752e4700d91bb2a41

commit 2b80c18a812ebbabe740563752e4700d91bb2a41
Author: xixuan <xixuan@google.com>
Date: Mon Mar 28 18:59:30 2016

Autotest: Catch the ServoHost Creation Failure when using SSH tunnel.

When ServoHost is created using SSH tunnel, exceptions are not catched,
which directly stops the rest of DUT repair process.

This CL changes to catch the exceptions in ServoHost proxy creation.

BUG= chromium:598386 
TEST=Ran repair job for DUT in a local autotest instance.

Change-Id: I2bf361fb8491b0eb83fe65f9105f6feb83d2af32
Reviewed-on: https://chromium-review.googlesource.com/335417
Reviewed-by: Fang Deng <fdeng@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/2b80c18a812ebbabe740563752e4700d91bb2a41/server/hosts/servo_host.py

Comment 2 by benhenry@google.com, Apr 26 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS

Comment 3 by xixuan@chromium.org, Jun 9 2016

Status: Fixed (was: Assigned)

Comment 4 by abod...@chromium.org, Jun 27 2016 

Closing... please feel free to reopen if its not fixed.

Comment 5 by abod...@chromium.org, Jun 27 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment