New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598377 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 594803



Sign in to add a comment

MemoryInfra: net:: does not have trace events needed for heap profiler

Project Member Reported by ssid@chromium.org, Mar 28 2016

Issue description

Background context:go/memory-infra: memory profiling in chrome://tracing

The net:: namespace does not have TRACE_EVENT macros to trace the memory usage.

Doc: https://docs.google.com/document/d/1L_j3CjtXtCXec4ecFYK3J1BXBkK30ZtfVTEOr0Q43s4/view
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d6b40100156b2dabcc79cf46f9f34f225e21d0a

commit 6d6b40100156b2dabcc79cf46f9f34f225e21d0a
Author: ssid <ssid@chromium.org>
Date: Tue Apr 05 18:59:56 2016

Add TRACE_EVENT macros to net.

This CL adds TRACE_EVENT macros to some of the interesting functions in
net which are useful to track memory usage.
These are points suggested by statistics from local experiments and
improvised by mmenke@.

The CL also changes the categories of some existing trace events and
cleans up some. Some events are marked under DISABLED_BY_DEFAULT
category since there are too many calls and should not crowd default
tracing with lot of points. This is chosen based on an average value
of trace events in other categories.

BUG= 598377 

Review URL: https://codereview.chromium.org/1834273002

Cr-Commit-Position: refs/heads/master@{#385246}

[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/chrome/browser/net/crl_set_fetcher.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/base/network_delegate.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/base/network_quality_estimator.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/cert/crl_set_storage.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/cert/multi_threaded_cert_verifier.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/disk_cache/blockfile/in_flight_io.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/dns/host_cache.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/proxy/proxy_resolver_v8_tracing.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/quic/quic_stream_factory.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/socket/client_socket_handle.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/socket/socket_posix.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/socket/ssl_client_socket_openssl.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/socket/transport_client_socket_pool.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/spdy/spdy_session.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/udp/udp_socket_posix.cc
[modify] https://crrev.com/6d6b40100156b2dabcc79cf46f9f34f225e21d0a/net/url_request/url_request_http_job.cc

Comment 2 by ssid@chromium.org, Apr 7 2016

Blocking: 594803

Comment 3 by ssid@chromium.org, May 6 2016

Status: Fixed (was: Untriaged)
Marking this fixed.
As side note:
This was useful to make this report (internal to google, sorry):
https://docs.google.com/document/d/1sOo9PQLaXQ64jofg7l1bTsaRsmJfQmpWl0HAeqt-luA/edit?usp=sharing

Comment 4 by ssid@chromium.org, May 6 2016

Owner: ssid@chromium.org
Components: Internals>Instrumentation>Memory

Sign in to add a comment