New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598360 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 598264
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Disable DownloadContentTest.RedirectBeforeResume

Project Member Reported by sorin@chromium.org, Mar 28 2016

Issue description

Disable DownloadContentTest.RedirectBeforeResume

It makes the bot Windows-7-SP1 sad.

content_browsertests on Windows-7-SP1 content_browsertests on Windows-7-SP1 106 disabled 6 flaky failed 1
failures:
DownloadContentTest.RedirectBeforeResume

Retrying 7 tests (retry #1)
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_29310" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_29310" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_29310" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
[ RUN      ] DownloadContentTest.RedirectBeforeResume

[4268:4008:0328/093216:42313149:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[4604:3272:0328/093217:42314132:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[1315/1321] DownloadContentTest.RedirectBeforeResume (TIMED OUT)
[1316/1321] DumpAccessibilityTreeTest.AccessibilityIframeCoordinatesCrossProcess (14183 ms)
[1317/1321] RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation (4062 ms)
[1318/1321] SitePerProcessBrowserTest.CrossProcessFocusChangeFiresBlurEvents (7321 ms)
[1319/1321] SitePerProcessBrowserTest.NestedPopupMenuTest (12060 ms)
[1320/1321] SitePerProcessBrowserTest.SequentialFocusNavigation (5416 ms)
[1321/1321] SitePerProcessBrowserTest.SubframeWindowFocus (4030 ms)
Retrying 1 test (retry #2)
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_27664" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_27664" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_27664" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
[ RUN      ] DownloadContentTest.RedirectBeforeResume

[2968:1216:0328/093348:42405346:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[4420:1380:0328/093350:42406391:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[1322/1322] DownloadContentTest.RedirectBeforeResume (TIMED OUT)
Retrying 1 test (retry #3)
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_28776" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_28776" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_28776" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
[ RUN      ] DownloadContentTest.RedirectBeforeResume

[4180:4992:0328/093434:42450726:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[3224:1776:0328/093435:42451990:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[1323/1323] DownloadContentTest.RedirectBeforeResume (TIMED OUT)
1 test timed out:

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/398e8213d0bbc5235b64b3bd07c1a248f70b6188

commit 398e8213d0bbc5235b64b3bd07c1a248f70b6188
Author: sorin <sorin@chromium.org>
Date: Mon Mar 28 18:32:18 2016

Disable DownloadContentTest.RedirectBeforeResume

It makes the bot Windows-7-SP1 sad.

content_browsertests on Windows-7-SP1 content_browsertests on Windows-7-SP1 106 disabled 6 flaky failed 1
failures:
DownloadContentTest.RedirectBeforeResume

Retrying 7 tests (retry #1)
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_29310" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_29310" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_29310" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
[ RUN      ] DownloadContentTest.RedirectBeforeResume

[4268:4008:0328/093216:42313149:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[4604:3272:0328/093217:42314132:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[1315/1321] DownloadContentTest.RedirectBeforeResume (TIMED OUT)
[1316/1321] DumpAccessibilityTreeTest.AccessibilityIframeCoordinatesCrossProcess (14183 ms)
[1317/1321] RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation (4062 ms)
[1318/1321] SitePerProcessBrowserTest.CrossProcessFocusChangeFiresBlurEvents (7321 ms)
[1319/1321] SitePerProcessBrowserTest.NestedPopupMenuTest (12060 ms)
[1320/1321] SitePerProcessBrowserTest.SequentialFocusNavigation (5416 ms)
[1321/1321] SitePerProcessBrowserTest.SubframeWindowFocus (4030 ms)
Retrying 1 test (retry #2)
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_27664" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_27664" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_27664" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
[ RUN      ] DownloadContentTest.RedirectBeforeResume

[2968:1216:0328/093348:42405346:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[4420:1380:0328/093350:42406391:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[1322/1322] DownloadContentTest.RedirectBeforeResume (TIMED OUT)
Retrying 1 test (retry #3)
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_28776" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_28776" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4252_12854\d4252_28776" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectBeforeResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outmrkg2q\output.json" --use-fake-device-for-media-stream
[ RUN      ] DownloadContentTest.RedirectBeforeResume

[4180:4992:0328/093434:42450726:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[3224:1776:0328/093435:42451990:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[1323/1323] DownloadContentTest.RedirectBeforeResume (TIMED OUT)
1 test timed out:

TBR=ahendrickson
BUG= 598360 

Review URL: https://codereview.chromium.org/1839703002

Cr-Commit-Position: refs/heads/master@{#383525}

[modify] https://crrev.com/398e8213d0bbc5235b64b3bd07c1a248f70b6188/content/browser/download/download_browsertest.cc

Comment 2 by asanka@chromium.org, Mar 28 2016

Mergedinto: 598264
Status: Duplicate (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8567277cbf31767a774279c56ab3d7a1592bd0b

commit a8567277cbf31767a774279c56ab3d7a1592bd0b
Author: sorin <sorin@chromium.org>
Date: Mon Mar 28 21:34:07 2016

Disable two download tests on Windows.

DownloadContentTest.RedirectWhileResume
DownloadContentTest.BadRangeHeader

They make this bot sad:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29

[1323/1324] DownloadContentTest.BadRangeHeader (TIMED OUT)
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir1128_14655\d1128_31601" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectWhileResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outa4f6wq\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir1128_14655\d1128_31601" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectWhileResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outa4f6wq\output.json" --use-fake-device-for-media-stream
Still waiting for the following processes to finish:
	".\content_browsertests.exe" --brave-new-test-launcher --data-path="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir1128_14655\d1128_31601" --gtest_also_run_disabled_tests --gtest_filter=DownloadContentTest.RedirectWhileResume --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\work\isolated\outa4f6wq\output.json" --use-fake-device-for-media-stream
[ RUN      ] DownloadContentTest.RedirectWhileResume

[6356:4968:0328/133407:41369873:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[8148:1008:0328/133407:41370185:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[2648:5492:0328/133407:41370263:WARNING:histogram_base.cc(131)] 2 histograms were created before reporting was enabled.

[1324/1324] DownloadContentTest.RedirectWhileResume (TIMED OUT)

TBR=asanka@chromium.org
BUG= 598360 

Review URL: https://codereview.chromium.org/1839763002

Cr-Commit-Position: refs/heads/master@{#383570}

[modify] https://crrev.com/a8567277cbf31767a774279c56ab3d7a1592bd0b/content/browser/download/download_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da82ea55fc1575d1950234bdebf54001c44f5a73

commit da82ea55fc1575d1950234bdebf54001c44f5a73
Author: asanka <asanka@chromium.org>
Date: Wed Mar 30 16:04:50 2016

[Downloads] Fix copy and move operators for TestDownloadRequestHandler.

The 'support_byte_ranges' member was not being initialized during a copy
or move assignment. Interestingly, this was causing subtle flakiness
only on Windows.

BUG= 598360 

Review URL: https://codereview.chromium.org/1838963002

Cr-Commit-Position: refs/heads/master@{#383985}

[modify] https://crrev.com/da82ea55fc1575d1950234bdebf54001c44f5a73/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/da82ea55fc1575d1950234bdebf54001c44f5a73/content/public/test/test_download_request_handler.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da82ea55fc1575d1950234bdebf54001c44f5a73

commit da82ea55fc1575d1950234bdebf54001c44f5a73
Author: asanka <asanka@chromium.org>
Date: Wed Mar 30 16:04:50 2016

[Downloads] Fix copy and move operators for TestDownloadRequestHandler.

The 'support_byte_ranges' member was not being initialized during a copy
or move assignment. Interestingly, this was causing subtle flakiness
only on Windows.

BUG= 598360 

Review URL: https://codereview.chromium.org/1838963002

Cr-Commit-Position: refs/heads/master@{#383985}

[modify] https://crrev.com/da82ea55fc1575d1950234bdebf54001c44f5a73/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/da82ea55fc1575d1950234bdebf54001c44f5a73/content/public/test/test_download_request_handler.cc

Comment 6 by asanka@chromium.org, Mar 30 2016

Owner: asanka@chromium.org
Status: Fixed (was: Duplicate)

Comment 7 by asanka@chromium.org, Mar 30 2016

Cc: ahendrickson@chromium.org asanka@chromium.org
 Issue 598264  has been merged into this issue.

Sign in to add a comment