New issue
Advanced search Search tips

Issue 598344 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

AddressSanitizerTests.TestAddressSanitizer failing on win/asan bots

Project Member Reported by thakis@chromium.org, Mar 28 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%20tester/builds/943/steps/sbox_integration_tests/logs/AddressSanitizerTests.TestAddressSanitizer

AddressSanitizerTests.TestAddressSanitizer (run #1):
[ RUN      ] AddressSanitizerTests.TestAddressSanitizer
..\..\sandbox\win\srcddress_sanitizer_test.cc(96): error: Value of: strstr(data.c_str(), strrchr(__FILE__, '\'))
  Actual: false
Expected: true
The stack trace doesn't have a correct filename:
=================================================================
==4936==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x04a01c18 at pc 0x00f411bd bp 0xdeadbeef sp 0x0032fb90
WRITE of size 4 at 0x04a01c18 thread T0
    #3 0x158026b in __scrt_common_main_seh f:\ddctools\crtcstartup\src\startup\exe_common.inl:264
    #4 0x75f33379 in BaseThreadInitThunk+0x11 (C:\Windows\syswow64\kernel32.dll+0x13379)
    #5 0x77d39881 in RtlInitializeExceptionChain+0x62 (C:\Windows\SysWOW64
tdll.dll+0x39881)
    #6 0x77d39854 in RtlInitializeExceptionChain+0x35 (C:\Windows\SysWOW64
tdll.dll+0x39854)

0x04a01c18 is located 0 bytes to the right of 168-byte region [0x04a01b70,0x04a01c18)
allocated by thread T0 here:
    #0 0x1569be8 in malloc c:uild\slave\crwinasanuild\src	hird_party\llvm\projects\compiler-rt\libsansan_malloc_win.cc:63
    #1 0x157fdc6 in operator new f:\ddctools\crtcstartup\src\heap
ew_scalar.cpp:19
    #5 0x158026b in __scrt_common_main_seh f:\ddctools\crtcstartup\src\startup\exe_common.inl:264
    #6 0x75f33379 in BaseThreadInitThunk+0x11 (C:\Windows\syswow64\kernel32.dll+0x13379)
    #7 0x77d39881 in RtlInitializeExceptionChain+0x62 (C:\Windows\SysWOW64
tdll.dll+0x39881)
    #8 0x77d39854 in RtlInitializeExceptionChain+0x35 (C:\Windows\SysWOW64
tdll.dll+0x39854)



Possibly triggered by https://chromium.googlesource.com/chromium/src/+/f9b843b964801440b50e74b072c70e7ecb0f1921%5E%21/#F5 somehow, but it's also the first test run on the bot in 11 days.
 

Comment 1 by thakis@chromium.org, Mar 29 2016

Durr right, you mentioned I broke this with the fastbuild change last week. I already forgot that again, sorry :-/
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9fefb873b684ccd3732a8859c3c8daa7635da2e

commit a9fefb873b684ccd3732a8859c3c8daa7635da2e
Author: rnk <rnk@chromium.org>
Date: Tue Mar 29 02:41:03 2016

Enable symbols with ASan

This sets -gline-tables-only to try to keep linking fast. This is
consistent with other platforms, which do the same for DWARF.

R=thakis@chromium.org
BUG= 598344 

Review URL: https://codereview.chromium.org/1840873002

Cr-Commit-Position: refs/heads/master@{#383659}

[modify] https://crrev.com/a9fefb873b684ccd3732a8859c3c8daa7635da2e/build/common.gypi
[modify] https://crrev.com/a9fefb873b684ccd3732a8859c3c8daa7635da2e/build/config/compiler/compiler.gni
[modify] https://crrev.com/a9fefb873b684ccd3732a8859c3c8daa7635da2e/build/config/sanitizers/BUILD.gn

Comment 3 by thakis@chromium.org, Mar 29 2016

Owner: r...@chromium.org
Status: Fixed (was: Untriaged)
Thanks!

Sign in to add a comment