The Failing connection test was not returning the correct promise so no one noticed that the right promise started to reject when new errors were added to BluetoothDevice::ConnectErrorCode.
As discussed in https://docs.google.com/document/d/1zxDxK77EPqxocOzooGLaDl5lUhg7HTUaTSlbZkfu3KQ/edit, moving some issues determined to not be ship blocking to be under 'future' issue 577974 instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9187d13054b869580045f81d8d55f84c6cf150fa commit 9187d13054b869580045f81d8d55f84c6cf150fa Author: ortuno <ortuno@chromium.org> Date: Tue Mar 14 03:47:08 2017 bluetooth: Clean up connection error messages Android documentation is incomplete when it comes to connection error codes, which led us to believe that all values documented here[1] could be returned by the platform. We opened http://crbug.com/531058 to include all these values in our ConnectErrorCode enum. http://crrev.com/1464443002 was then submitted to include all these values in our enum. Upon further investigation we realized that these values were not being returned by the platform and needed to be removed from our ConnectErrorCode enum. This patch reverts the changes in http://crrev.com/1464443002 which means: 1. Removing the values from the enum 2. Changing all clients' switch statements that used the enum 3. Fixing test that used these values 4. Removing strings that described these errors Also http://crrev.com/1464443002 broke a test this patch also fixes that test. [1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html BUG= 598341 , 578191 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727683003 Cr-Commit-Position: refs/heads/master@{#456617} [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.js [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/chrome/test/data/extensions/api_test/bluetooth_low_energy/gatt_connection/runtest.js [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/content/browser/bluetooth/bluetooth_metrics.h [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/device/bluetooth/public/interfaces/adapter.mojom [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/device/bluetooth/public/interfaces/connect_result_type_converter.h [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/extensions/browser/api/bluetooth/bluetooth_private_api.cc [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.cc [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/extensions/common/api/bluetooth_private.idl [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-fails.html [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/third_party/closure_compiler/externs/bluetooth_private.js [modify] https://crrev.com/9187d13054b869580045f81d8d55f84c6cf150fa/tools/metrics/histograms/histograms.xml
Comment 1 by scheib@chromium.org
, Aug 5 2016