New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598316 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

clang/win gn build broken after webrtc change

Project Member Reported by thakis@chromium.org, Mar 28 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/4288/steps/compile/logs/stdio

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/third_party/libjingle/libjingle_webrtc_common/webrtcmediaengine.obj.rsp /c ../../third_party/webrtc/media/engine/webrtcmediaengine.cc /Foobj/third_party/libjingle/libjingle_webrtc_common/webrtcmediaengine.obj /Fdobj/third_party/libjingle/libjingle_webrtc_common_cc.pdb
In file included from ../../third_party/webrtc/media/engine/webrtcmediaengine.cc:11:
In file included from ../../third_party\webrtc/media/engine/webrtcmediaengine.h:17:
In file included from ../../third_party\webrtc/config.h:19:
In file included from ../../third_party\webrtc/common.h:16:
../../third_party\webrtc/base/basictypes.h(18,10) :  error: #include resolved using non-portable Microsoft search rules as: ../../third_party\webrtc/config.h [-Werror,-Wmicrosoft-include]
#include "config.h"  // NOLINT
         ^


Due to  https://codereview.chromium.org/1808233002


I vaguely remember seeing this on a try job a last week during the short window that win_clang_x64_dbg was part of the default cq config...hm yes, see my comment on https://codereview.chromium.org/1808233002/
 

Comment 1 by thakis@chromium.org, Mar 28 2016

Oh, that's the same CL!
Cc: -kjellander@chromium.org
Owner: kjellander@chromium.org
Status: Assigned (was: Untriaged)
I'm cleaning up the config.h includes in https://codereview.webrtc.org/1820023004/ and will roll that into Chromium before attempting to reland this.

Comment 3 by thakis@chromium.org, Mar 30 2016

Status: Fixed (was: Assigned)
https://codereview.chromium.org/1839063005/ relanded without issues. Thanks!

Sign in to add a comment