New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598314 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

ServiceWorker.StartWorker.Status has elevated DISK_CACHE errors on the last few canaries

Project Member Reported by falken@chromium.org, Mar 28 2016

Issue description

Status: Started (was: Assigned)
I'm now investigating...
Hmmm... both ServiceWorker.Database.OpenResult and ServiceWorker.DiskCache.ReadResponseResult have been bad since 51.0.2687.0.
For reference, this is the list of changes between 51.0.2686.0 and 51.0.2687.0:
https://chromium.googlesource.com/chromium/src/+log/51.0.2686.0..51.0.2687.0?pretty=fuller&n=10000

Comment 4 by horo@chromium.org, Mar 31 2016

Labels: OS-All
This CL has changed the storage path.
https://crrev.com/1737933002/#msg42

Comment 5 by falken@chromium.org, Mar 31 2016

Labels: -OS-Chrome -OS-Mac M-51
Owner: horo@chromium.org
horo@, thank you for investigating this. Let me assign this to you.

Comment 7 by horo@chromium.org, Apr 1 2016

Cc: e...@chromium.org
Labels: ReleaseBlock-Dev
I think this issue is serious enough to set ReleaseBlock-Dev.

Comment 8 by horo@chromium.org, Apr 1 2016

Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Ah it's already on Dev.
Changed to ReleaseBlock-Beta.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ee3cce199999c1b21c7cdf9d3f0e19cbc752e1b

commit 4ee3cce199999c1b21c7cdf9d3f0e19cbc752e1b
Author: horo <horo@chromium.org>
Date: Sun Apr 03 10:01:50 2016

Set the data path of StoragePartition correctly.

https://crrev.com/1737933002 accidentally changed the path which is used while
initializing IndexedDBContextImpl, CacheStorageContextImpl,
ServiceWorkerContextWrapper, WebRTCIdentityStore and
PlatformNotificationContextImpl.

This |path| must be |partition_path| when |in_memory| is false.

BUG= 598314 , 586194 

Review URL: https://codereview.chromium.org/1844843004

Cr-Commit-Position: refs/heads/master@{#384829}

[modify] https://crrev.com/4ee3cce199999c1b21c7cdf9d3f0e19cbc752e1b/content/browser/storage_partition_impl.cc

Comment 10 by horo@chromium.org, Apr 5 2016

Status: Fixed (was: Started)

Sign in to add a comment