[Regression]: Browser crash is seen on navigating to chrome://suggestions in guest mode |
|||||
Issue descriptionVersion: 51.0.2692.0 dev OS: Ubuntu 12.04,14.04,windows What steps will reproduce the problem? (1) Launch chrome and browse as Guest >> Navigate to chrome://suggestions and wait Expected: No crash should be seen on navigating to chrome://suggestions Actual: Instead Browser crashes on navigating This is a regression issue broken in M51. Will provide bisect info soon. Crash Ids: cff08fb800000000 , 8b5e80e400000000
,
Mar 28 2016
Users experienced this crash on the following builds: Mac Canary 51.0.2692.0 - 2 reports, 2 clients (signature suggestions::SuggestionsSource::StartDataRequest) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Mar 28 2016
Good Build: 51.0.2674.0 dev Bad Build: 51.0.2675.0 dev CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/801186267c23a3e727f2aac27712bf7d3a620370..1bd05dea011e4b63d2cbca323c414d3f29507b57 Suspecting https://codereview.chromium.org/1770843002 from changelog @treib: Please help in re-assigning if it is not related to your change.
,
Mar 29 2016
Yup, this is probably mine. Looking.
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1992d036cbc12e6e0131fafd7a5e7d62d5105098 commit 1992d036cbc12e6e0131fafd7a5e7d62d5105098 Author: treib <treib@chromium.org> Date: Tue Mar 29 13:02:00 2016 Handle null SuggestionsService in chrome://suggestions SuggestionsService can be null in guest profiles, so we return the fallback value in that case. BUG= 598253 Review URL: https://codereview.chromium.org/1842733002 Cr-Commit-Position: refs/heads/master@{#383707} [modify] https://crrev.com/1992d036cbc12e6e0131fafd7a5e7d62d5105098/chrome/browser/search/suggestions/suggestions_source.cc
,
Mar 29 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ajha@chromium.org
, Mar 28 2016Status: Untriaged (was: Unconfirmed)