flag-specific expected results |
|||||
Issue descriptionTo go along with flag-specific test expectations in LayoutTests/FlagExpectations (added in http://crrev.com/361584), we should support flag-specific expected results for cases where a flag deliberately changes the output of a test. For example, tests that dump internals.layerTreeAsText produce slightly different text output with --root-layer-scrolls, due to the LayoutView's CompositedLayerMapping. Currently these are marked as failing, but the correct fix is to expect the new result. We should incorporate these into the logic in run-webkit-tests for looking up expected results, similar to the way we consult platform-specific expectations under LayoutTests/platform.
,
Mar 28 2016
Good question, we could have platform expectations inside the flag-specific expectations.
,
May 18 2016
,
May 18 2016
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
,
Jun 25 2016
This is test related.
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb611802648d0dc0c896de3e641fce63e92f756 commit 2fb611802648d0dc0c896de3e641fce63e92f756 Author: skobes <skobes@chromium.org> Date: Tue Jul 26 02:14:29 2016 Add flag-specific baseline search path to run-webkit-tests. BUG= 598180 Review-Url: https://codereview.chromium.org/2182813002 Cr-Commit-Position: refs/heads/master@{#407685} [modify] https://crrev.com/2fb611802648d0dc0c896de3e641fce63e92f756/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py [modify] https://crrev.com/2fb611802648d0dc0c896de3e641fce63e92f756/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
,
Sep 2 2016
What else is there left to do for this?
,
Sep 2 2016
,
Sep 2 2016
Excellent :-) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ojan@chromium.org
, Mar 28 2016