rewrite_to_chrome_style clobbers s_ prefix. |
||
Issue descriptionIn WTF.cpp, there's: bool s_initialized; bool s_shutdown; void (*s_callOnMainThreadFunction)(MainThreadFunction, void*); ThreadIdentifier s_mainThreadIdentifier; After the rename, they become: bool initialized; bool shutdown; void (*call_on_main_thread_function)(MainThreadFunction, void*); ThreadIdentifier main_thread_identifier; While s_ here isn't strictly correct, removing s_ also causes a naming collision.
,
Mar 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71dbc98da81b7d8a758a674b1971672bf1573556 commit 71dbc98da81b7d8a758a674b1971672bf1573556 Author: dcheng <dcheng@chromium.org> Date: Mon Mar 28 20:46:50 2016 rewrite_to_chrome_style: making globals great again. Prefix globals at translation unit / namespace scope to reduce the chance of a naming collision. BUG= 598175 Review URL: https://codereview.chromium.org/1839573002 Cr-Commit-Position: refs/heads/master@{#383556} [modify] https://crrev.com/71dbc98da81b7d8a758a674b1971672bf1573556/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp [modify] https://crrev.com/71dbc98da81b7d8a758a674b1971672bf1573556/tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc [modify] https://crrev.com/71dbc98da81b7d8a758a674b1971672bf1573556/tools/clang/rewrite_to_chrome_style/tests/variables-original.cc [modify] https://crrev.com/71dbc98da81b7d8a758a674b1971672bf1573556/tools/clang/rewrite_to_chrome_style/tests/wtf-expected.cc
,
Mar 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dcheng@chromium.org
, Mar 27 2016Status: Started (was: Available)