Don't parse a single & as an empty parameter in "Query String Parameters"
Reported by
l446240525@gmail.com,
Mar 26 2016
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2689.0 Safari/537.36 Steps to reproduce the problem: I don't know if this is an intended behaviour or a bug. What is the expected behavior? What went wrong? . Did this work before? No Chrome version: 51.0.2689.0 Channel: n/a OS Version: OS X 10.10.4 Flash Version: Shockwave Flash 21.0 r0
,
Mar 28 2016
Whats the spec say about starting the query params with a &? I think technically that's an empty param. I kinda think we'd want to show the user that, as it seems like a mistake.
,
Mar 28 2016
Ref spec: I am unable to find how it *directly* addresses this problem. However, talking it over just now we decided that it could be useful for debugging purposes to show empty items (primarily thinking about poorly developed backends.) However, the UX we currently have is non-intuitive. Attached is an example of what we could do instead to let developers know empty pairs are being sent.
,
Mar 28 2016
Doing a little more digging around, it looks as if *anything* after the query parameter goes until you hit a hashtag. Ref: http://stackoverflow.com/a/4557763/2604748 Therefore, it is conceivable (that for some reason) an application may depend upon empty query parameters for something. Best show that these do exist compared to outright ignoring them in parsing, just in case.
,
Mar 28 2016
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14d5974a300bf83db67442db00ab61b08851a81a commit 14d5974a300bf83db67442db00ab61b08851a81a Author: jonathan.garbee <jonathan.garbee@chromium.org> Date: Thu May 12 23:23:44 2016 DevTools: Address empty query parameters being displayed fugly. BUG= 598150 Review-Url: https://codereview.chromium.org/1832413002 Cr-Commit-Position: refs/heads/master@{#393393} [modify] https://crrev.com/14d5974a300bf83db67442db00ab61b08851a81a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js [modify] https://crrev.com/14d5974a300bf83db67442db00ab61b08851a81a/third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css
,
May 12 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jonathan.garbee@chromium.org
, Mar 28 2016Labels: -OS-Mac OS-All
Owner: jonathan.garbee@chromium.org
Status: Assigned (was: Unconfirmed)