file:///data/data/... shown after page refresh of removed saved offline page |
||||
Issue descriptionVersion: 51.1.2687.0 dev (32-bit) OS: Android 5 & Android 4 What steps will reproduce the problem? (1)Save an offline page (2)Go offline, open the saved page (3)Click the star in address box to edit the bookmark, click REMOVE to remove the offline page saved (4)Refresh the page What is the expected output? Showing page with message "You are offline", see screenshot expected What do you see instead? Message "Your file was not found", in address box showing file:///data/data/..., see screenshot actual Please use labels and text to provide additional information.
,
Mar 30 2016
I agree that it makes sense to show the offline dino here.
,
Apr 1 2016
To generalize based on another issue Darin highlighted (below), I believe the user experience we want here is to fall back to the original URL. So, if a user is offline, they'd get the offline dino page, and if online they'd get the original page. The user flow that Darin highlighted from playing around with the feature is below. Would be good to validate that our fix addresses this as well! Steps to reproduce 1. viewing an offline bookmark in a tab 2. go into the bookmarks manager and delete the storage for the offline bookmark 3. switch back to the tab where that was loaded 4. see an error page and the file:// URL will appear in the location bar. Expected Behavior: - should fall back to the original site URL
,
Apr 11 2016
This bug occurs because all the metadata information about an offline page is lost after the page was deleted. I can add the logic to track the deleted pages. 1) Using in-memory buffer. This buffer is a circular buffer with 20 item limits (we don't want to track unlimited pages). This means that we're not able to get back the online URL when the page was deleted before 20 more pages were deleted. Also we're not able to get back the online URL when Chrome is killed and restarted. 2) Still keeping pages in metadata store, with DELETED state. We need to wipe out these entries, say in one day. For any of the above solutions, there is still a chance that the online URL for the deleted page can not longer be retrieved. What are we going to show in this case? The ultimate fix is to add the capability to support double URLs for a navigation entry. This is a big workitem, which will require lots of discussions with navigation team, plus designs and implementations. Talo, how do you think about fixing this bug?
,
Jun 30 2016
This should have already been fixed with 2-stage deletion.
,
Aug 8 2016
Verified Fixed in 54.0.2821.0 If a bookmark is removed per the repro steps, the offline copy remains and is still available. If that copy gets deleted by Chrome cleaning it up, then the original url is displayed with an offline error page. If the offline copy is manually removed, and a tab with the offline copy is reloaded. The error page still shows the original url but with a File Not Found error page, but since someone would have to do a lot of work to make that happen I think its fine to have that as an error page. |
||||
►
Sign in to add a comment |
||||
Comment 1 by fgor...@chromium.org
, Mar 30 2016Labels: -Restrict-View-Google
Owner: jianli@chromium.org
Status: Assigned (was: Untriaged)