Updating Clank onboarding |
|||||||||
Issue descriptionAndroid The onboarding text doesn't thoroughly explain what the Physical Web does. The biggest points of confusion are: - How are these pages getting to my device (i.e. what is a nearby page)? - How can I get more details around how this works (small, but power-user request)
,
Apr 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97069b19e5cbd4594ff612e258c12d4bdddd06c0 commit 97069b19e5cbd4594ff612e258c12d4bdddd06c0 Author: mattreynolds <mattreynolds@chromium.org> Date: Fri Apr 01 23:58:33 2016 Improve clarity of the Physical Web opt-in notification message Previously: "Physical Web pages are nearby / Use Chrome to browse them" Now: "Web pages are nearby / View them in Chrome" This is a strings-only change. BUG= 598106 Review URL: https://codereview.chromium.org/1852813002 Cr-Commit-Position: refs/heads/master@{#384735} [modify] https://crrev.com/97069b19e5cbd4594ff612e258c12d4bdddd06c0/chrome/android/java/strings/android_chrome_strings.grd
,
Apr 4 2016
Do we want to merge this?
,
Apr 4 2016
Yes, we should merge it. I have one more CL for this bug: https://codereview.chromium.org/1844223005/ We had discussed adding a Learn More link to the interstitial, but I decided against it for this CL since it would require significant changes to the activity.
,
Apr 4 2016
[Automated comment] GRD changes detected, less than 3 weeks to before stable release of M50, manual review required.
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba5127254e67274c1c423db618a27233ef8175b commit fba5127254e67274c1c423db618a27233ef8175b Author: mattreynolds <mattreynolds@chromium.org> Date: Mon Apr 04 20:56:19 2016 Improve clarity of Physical Web onboarding interstitial message Previously: Chrome can now find and show you nearby web pages using Bluetooth. Chrome will scan for nearby pages when your device is unlocked. These pages will go through a Google service to improve the quality of page results. You can control the Physical Web in Chrome privacy settings. Now: Devices nearby you are broadcasting web pages over Bluetooth. Chrome will scan for nearby pages and display them when you wake up your device. These pages will go through a Google service to improve the quality of page results. You can control the Physical Web in Chrome Settings. This is a strings-only change. BUG= 598106 Review URL: https://codereview.chromium.org/1844223005 Cr-Commit-Position: refs/heads/master@{#384999} [modify] https://crrev.com/fba5127254e67274c1c423db618a27233ef8175b/chrome/android/java/strings/android_chrome_strings.grd
,
Apr 4 2016
,
Apr 6 2016
Just spoke with animohan@ who indicated English-only strings would be OK for M50, so you're OK to merge to M50 branch 2661. Please merge ASAP.
,
Apr 7 2016
Just spoke with ryanm@ -- he said we can have the strings translated by 4/11 (Mon)
,
Apr 7 2016
L10n project ID 418659 has been kicked off for the following TC strings. 7572235201647709598 - "View them in Chrome" 6632906156170898155 - "Web pages are nearby" 5299339297875036960 - "Devices nearby you are broadcasting web pages over Bluetooth. Chrome will scan for pages and display them when you wake up your device. These pages will go through a Google service to improve the quality of page results. You can control the Physical Web in Chrome Settings." Current ETA is EOD Monday (4/11). Please let me know if you have any questions. Thanks!
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25e94e57eaae486d0932639162b446084e90a94b commit 25e94e57eaae486d0932639162b446084e90a94b Author: Tommy Nyquist <nyquist@chromium.org> Date: Fri Apr 08 00:54:12 2016 Improve clarity of Physical Web onboarding interstitial message Previously: Chrome can now find and show you nearby web pages using Bluetooth. Chrome will scan for nearby pages when your device is unlocked. These pages will go through a Google service to improve the quality of page results. You can control the Physical Web in Chrome privacy settings. Now: Devices nearby you are broadcasting web pages over Bluetooth. Chrome will scan for nearby pages and display them when you wake up your device. These pages will go through a Google service to improve the quality of page results. You can control the Physical Web in Chrome Settings. This is a strings-only change. BUG= 598106 Review URL: https://codereview.chromium.org/1844223005 Cr-Commit-Position: refs/heads/master@{#384999} (cherry picked from commit fba5127254e67274c1c423db618a27233ef8175b) Review URL: https://codereview.chromium.org/1872433003 . Cr-Commit-Position: refs/branch-heads/2661@{#522} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/25e94e57eaae486d0932639162b446084e90a94b/chrome/android/java/strings/android_chrome_strings.grd
,
Apr 8 2016
For the record, this CL also landed: ### commit e168331bf821ad99c8aa0765e629e99de2ba2a96 [log] [tgz] author Tommy Nyquist <nyquist@chromium.org> Fri Apr 08 00:49:00 2016 committer Tommy Nyquist <nyquist@chromium.org> Fri Apr 08 00:51:36 2016 tree cae99de8a354c62dbc583b6fd72fe2eed5cff192 parent 0e1ae5860dfc8a16b00545b8be3c89f1c77260e0 [diff] Improve clarity of the Physical Web opt-in notification message Previously: "Physical Web pages are nearby / Use Chrome to browse them" Now: "Web pages are nearby / View them in Chrome" This is a strings-only change. BUG= 598106 Review URL: https://codereview.chromium.org/1852813002 Cr-Commit-Position: refs/heads/master@{#384735} (cherry picked from commit 97069b19e5cbd4594ff612e258c12d4bdddd06c0) Review URL: https://codereview.chromium.org/1869273002 . Cr-Commit-Position: refs/branch-heads/2661@{#521} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} ###
,
Apr 11 2016
,
Apr 11 2016
This L10n request is complete. All strings have been translated and reviewed. Please let me know if you have any questions. Thnx!
,
May 2 2016
I'm still investigating adding a Learn More link to the opt-in interstitial. It's simple to add the link, but navigating backward from the help page is broken due to the way we launch the interstitial activity. (In short: Launching the interstitial from a notification creates the activity in a different task from the main Chrome task. Activities in the same task share a back stack, so for the back-nav to work the Learn More tab needs to be in the same task as the interstitial.)
,
May 3 2016
To work around this we can open the Learn More link in a ChromeCustomTab that lives in the same task as the interstitial. This will make the back navigation work as expected but could cause confusion if the user navigates away without completing the onboarding flow. eg: A user opens Learn More, then opens another app. On launching Chrome again from the home screen, it will open the Learn More tab instead of a "normal" tab activity.
,
May 4 2016
Screenshots for https://chromiumcodereview.appspot.com/1947693002/ Physical Web opt-in activity with Learn More link: https://screenshot.googleplex.com/8sOA0KwMn1j Physical Web help page open in a Chrome custom tab: https://screenshot.googleplex.com/3bxN0G8uer9
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e00ccbd44a59caa3d56a4af2b5393ef9b288ad94 commit e00ccbd44a59caa3d56a4af2b5393ef9b288ad94 Author: mattreynolds <mattreynolds@chromium.org> Date: Thu May 05 00:06:13 2016 Add a Learn More link to the Physical Web opt-in activity BUG= 598106 Review-Url: https://codereview.chromium.org/1947693002 Cr-Commit-Position: refs/heads/master@{#391706} [modify] https://crrev.com/e00ccbd44a59caa3d56a4af2b5393ef9b288ad94/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/e00ccbd44a59caa3d56a4af2b5393ef9b288ad94/chrome/android/java/res/layout/physical_web_optin.xml [modify] https://crrev.com/e00ccbd44a59caa3d56a4af2b5393ef9b288ad94/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java [modify] https://crrev.com/e00ccbd44a59caa3d56a4af2b5393ef9b288ad94/chrome/android/java/strings/android_chrome_strings.grd
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a42232196abfc73d0c710664595af8e1ff01146a commit a42232196abfc73d0c710664595af8e1ff01146a Author: cco3 <cco3@chromium.org> Date: Tue May 10 02:04:34 2016 Store scan timestamps with Physical Web URLs This change adds a timestamp to UrlInfo so that we can tell how long ago the URL was last seen. This will permit us to do smarter caching. BUG= 598106 , 596668 Review-Url: https://codereview.chromium.org/1966493002 Cr-Commit-Position: refs/heads/master@{#392515} [modify] https://crrev.com/a42232196abfc73d0c710664595af8e1ff01146a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java [modify] https://crrev.com/a42232196abfc73d0c710664595af8e1ff01146a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cb9951a5aa2edb978f434f31221b00bbc631ba0 commit 3cb9951a5aa2edb978f434f31221b00bbc631ba0 Author: cco3 <cco3@chromium.org> Date: Tue May 10 19:09:48 2016 Store Physical Web URL data in memory Instead of repeatedly reading and deserializing nearby URLs and resolved URLs, this change keeps them in memory. (There are not many URLs stored at one time, so memory shouldn't be an issue). This also paves the way for implementing a smarter cache in the UrlManager. BUG= 598106 , 596668 Review-Url: https://codereview.chromium.org/1894073006 Cr-Commit-Position: refs/heads/master@{#392671} [modify] https://crrev.com/3cb9951a5aa2edb978f434f31221b00bbc631ba0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java [modify] https://crrev.com/3cb9951a5aa2edb978f434f31221b00bbc631ba0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9f0e3cb412633e68d98b485c436998703f9b9dd commit f9f0e3cb412633e68d98b485c436998703f9b9dd Author: cco3 <cco3@chromium.org> Date: Thu May 12 18:02:18 2016 Extend the PhysicalWeb UrlManager cache 1. Instead of resetting the cache everytime the Physical Web starts, this change only resets the cache when we explicitly call stopPhysicalWeb(). 2. This allows the cache to grow up to 100 URLs, but kicks all that have been in the cache longer than 24 hours. BUG= 598106 , 596668 Review-Url: https://codereview.chromium.org/1971583002 Cr-Commit-Position: refs/heads/master@{#393299} [modify] https://crrev.com/f9f0e3cb412633e68d98b485c436998703f9b9dd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/f9f0e3cb412633e68d98b485c436998703f9b9dd/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3613ae3fbe705718127881c5dad8dc2d4fb536f commit e3613ae3fbe705718127881c5dad8dc2d4fb536f Author: cco3 <cco3@chromium.org> Date: Thu May 12 23:54:17 2016 Test Physical Web metadata serialization The PhysicalWeb has a cache of metadata that gets stored to local disk. This isn't absolutely required for mostly-correct functionality, so it's easy to overlook whether it's worker properly. This change tests that the cache works as intended. BUG= 598106 , 596668 Review-Url: https://codereview.chromium.org/1970743003 Cr-Commit-Position: refs/heads/master@{#393400} [modify] https://crrev.com/e3613ae3fbe705718127881c5dad8dc2d4fb536f/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java [modify] https://crrev.com/e3613ae3fbe705718127881c5dad8dc2d4fb536f/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java [modify] https://crrev.com/e3613ae3fbe705718127881c5dad8dc2d4fb536f/chrome/android/java_sources.gni [add] https://crrev.com/e3613ae3fbe705718127881c5dad8dc2d4fb536f/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java [modify] https://crrev.com/e3613ae3fbe705718127881c5dad8dc2d4fb536f/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
,
May 24 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by animohan@chromium.org
, Apr 1 2016Components: Internals>PhysicalWeb
Owner: mattreynolds@chromium.org
Status: Started (was: Untriaged)