New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598082 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 1
Type: Bug

Blocking:
issue 597790



Sign in to add a comment

Initial page load produces 3 compositor commits instead of just 1

Project Member Reported by kmarshall@chromium.org, Mar 25 2016

Issue description

When the Android application is started and the default page (e.g. google.com) is loaded, three full compositor commits are pushed to the client. No user interaction is required.

The commits can be seen by running vmodule="blimp_connection=2" on the engine to get detailed info on the outgoing messages. Grepping the log output for "type=COMPOSITOR" isolates the compositor messages from the rest of the noise. The commit messages are distinguishable from other messages by their large value for "byte_size".

[1234:1255:0325/150327:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=60796>
...
[1234:1255:0325/150330:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=60781>
...
[1234:1255:0325/150331:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=61642>
 
Navigating to other pages afterward transfers only 1 commit.

Comment 2 by w...@chromium.org, Mar 31 2016

Blocking: 597790

Comment 3 by mdw@chromium.org, Mar 31 2016

Cc: -khushals...@chromium.org
Owner: khushals...@chromium.org

Comment 4 by w...@chromium.org, Mar 31 2016

Components: -Mobile>Blimp Mobile>Blimp>Client
Labels: M-52

Comment 5 by w...@chromium.org, Apr 1 2016

Status: Assigned

Comment 6 by w...@chromium.org, Apr 1 2016

Labels: OS-Android OS-Linux
Status: WontFix (was: Assigned)
The engine is requesting commits as the page gets invalidated during layout. From an initial investigation into the commit messages when connected to a local engine, I see 5 commits and it looks like a significant chunk of the additional data is from resending images.

[1:1:0331/204542:ERROR:remote_channel_main.cc(163)] Starting commit serialization
[1:1:0331/204542:ERROR:remote_channel_main.cc(166)] Commit proto size: 9762
[1:1:0331/204542:ERROR:remote_channel_main.cc(163)] Starting commit serialization
[1:1:0331/204542:ERROR:blimp_image_serialization_processor.cc(93)] Sending image of size: 7630
[1:1:0331/204542:ERROR:remote_channel_main.cc(166)] Commit proto size: 23964
[1:1:0331/204543:ERROR:remote_channel_main.cc(163)] Starting commit serialization
[1:1:0331/204543:ERROR:blimp_image_serialization_processor.cc(89)] Re-sending image of size: 7630
[1:1:0331/204543:ERROR:blimp_image_serialization_processor.cc(93)] Sending image of size: 5100
[1:1:0331/204543:ERROR:blimp_image_serialization_processor.cc(93)] Sending image of size: 35356
[1:1:0331/204543:ERROR:remote_channel_main.cc(166)] Commit proto size: 60848
[1:1:0331/204544:ERROR:remote_channel_main.cc(163)] Starting commit serialization
[1:1:0331/204544:ERROR:blimp_image_serialization_processor.cc(89)] Re-sending image of size: 7630
[1:1:0331/204544:ERROR:blimp_image_serialization_processor.cc(89)] Re-sending image of size: 5100
[1:1:0331/204545:ERROR:blimp_image_serialization_processor.cc(89)] Re-sending image of size: 35356
[1:1:0331/204545:ERROR:remote_channel_main.cc(166)] Commit proto size: 60833
[1:1:0331/204545:ERROR:remote_channel_main.cc(163)] Starting commit serialization
[1:1:0331/204545:ERROR:blimp_image_serialization_processor.cc(89)] Re-sending image of size: 7630
[1:1:0331/204545:ERROR:blimp_image_serialization_processor.cc(89)] Re-sending image of size: 5100
[1:1:0331/204545:ERROR:blimp_image_serialization_processor.cc(89)] Re-sending image of size: 35356
[1:1:0331/204545:ERROR:remote_channel_main.cc(166)] Commit proto size: 61699

Commit#1
Total: 9762

Commit#2:
Total: 23964

Commit#3:
Total: 60848
Image Data resent: 7630

Commit#4:
Total: 60833
Image Data resent: 48086

Commit#5:
Total: 61699
Image Data resent: 48086

crbug/597807 is already tracking image caching which should eliminate these redundant transfers. Other than this, crbug/597816 is tracking investigation into the compositor messages to understand further optimizations to reduce data usage and crbug/599762 is tracking investigation into commit throttling on the engine.
Labels: Archive-Blimp

Sign in to add a comment