New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598073 link

Starred by 28 users

Issue metadata

Status: Started
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on: View detail
issue 715679
issue 787619
issue 789657
issue 803125
issue 805986
issue 821021
issue 824783
issue 827531
issue 827532
issue 872881
issue 872882
issue 872884
issue 872885
issue 872886
issue 904910
issue 920727
issue 561609
issue 580928
issue 607741
issue 611897
issue 612284
issue 612563
issue 622050
issue 624183
issue 700568
issue 703188
issue 704648
issue 706030
issue 706942
issue 712296
issue 713847
issue 713857
issue 715630
issue 715632
issue 715640
issue 715673
issue 715677
issue 715695
issue 717689
issue 717714
issue 717738
issue 720374
issue 721395
issue 721398
issue 721400
issue 721401
issue 721403
issue 721404
issue 721408
issue 721414
issue 724322
issue 724323
issue 729848
issue 729849
issue 732415
issue 737282
issue 740130
issue 746144
issue 746977
issue 753658
issue 754493
issue 754709
issue 754827
issue 754918
issue 756571
issue 756642
issue 756654
issue 759230
issue 761117
issue 769401
issue 776589
issue 777879
issue 782015
issue 782025
issue 783981
issue 784576
issue 785420
issue 787891
issue 789632
issue 789636
issue 789640
issue 789644
issue 789670
issue 789673
issue 792546
issue 796596
issue 797292
issue 798010
issue 803149
issue 803452
issue 803671
issue 803958
issue 810329
issue 810555
issue 810950
issue 817134
issue 819244
issue 820060
issue 820996
issue 821027
issue 822415
issue 824967
issue 824970
issue 824974
issue 824997
issue 825242
issue 826780
issue 835429
issue 837333
issue 837354
issue 838906
issue 838910
issue 838949
issue 840359
issue 840378
issue 840410
issue 840444
issue 840600
issue 841039
issue 841445
issue 841526
issue 841556
issue 844912
issue 844918
issue 844922
issue 844923
issue 844924
issue 844925
issue 844926
issue 844927
issue 844928
issue 844929
issue 844930
issue 844931
issue 844932
issue 844933
issue 844934
issue 844935
issue 844936
issue 844937
issue 844938
issue 844939
issue 844940
issue 844941
issue 844942
issue 844943
issue 844944
issue 844945
issue 844946
issue 844947
issue 844948
issue 844949
issue 844950
issue 844951
issue 844952
issue 844953
issue 844954
issue 844955
issue 844956
issue 844957
issue 844958
issue 844959
issue 844960
issue 844961
issue 844962
issue 844963
issue 844964
issue 844965
issue 844966
issue 844967
issue 844968
issue 844969
issue 844970
issue 844971
issue 844972
issue 844973
issue 844974
issue 844975
issue 844976
issue 844977
issue 844979
issue 844980
issue 844981
issue 844982
issue 844983
issue 844984
issue 844985
issue 844986
issue 844987
issue 844988
issue 844989
issue 844990
issue 845612
issue 847866
issue 848078
issue 848801
issue 855620
issue 857165
issue 859594
issue 863923
issue 865015
issue 865018
issue 865381
issue 872875
issue 872876
issue 872877
issue 872878
issue 872879
issue 872880
issue 872883
issue 872887
issue 872888
issue 872889
issue 872890
issue 873187
issue 876470
issue 876836
issue 877996
issue 879770
issue 879771
issue 879772
issue 879774
issue 879775
issue 879776
issue 879777
issue 879780
issue 879782
issue 879783
issue 879784
issue 892363
issue 898306

Blocking:
issue 267191
issue 598069
issue 695115
issue 705114
issue 715628
issue 824840
issue 824843
issue 824844
issue 824845
issue 824854
issue 824856
issue 824858
issue 846167
issue 712693


Show other hotlists

Hotlists containing this issue:
dmurph-tracking


Sign in to add a comment

Content Modularization Project: Network Service

Project Member Reported by jam@chromium.org, Mar 25 2016

Issue description

design doc: https://docs.google.com/document/d/1wAHLw9h7gGuqJNCgG1mP1BmLtCGfZ2pys-PdZQ1vg7M/edit?pref=2&pli=1#heading=h.w406cmqiibno

The initial goal is to isolate the networking related code in content/browser to a separate component. Then wrap it with Mojo interfaces such that it's possible to run it in a separate & sandboxed process.
 
Showing comments 165 - 264 of 264 Older
Blockedon: 778721
Blockedon: -778721
Blockedon: 782015
Blockedon: 782025
Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 170 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eede2ad7561d98b03a4c4513a95a78f2fbe09c7

commit 5eede2ad7561d98b03a4c4513a95a78f2fbe09c7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Nov 07 18:42:51 2017

Update network service browser_tests filter with new passing tests.

A number of changes landed last week that fixed basic failures.

BUG=598073
NOTRY=true
TBR=mmenke@chromium.org

Change-Id: I46d69a20556b7ea7fdab73ff081eb55197c814eb
Reviewed-on: https://chromium-review.googlesource.com/756828
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514520}
[modify] https://crrev.com/5eede2ad7561d98b03a4c4513a95a78f2fbe09c7/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Labels: Type-Task
Migrating S13N meta bugs to Type=Task, so that they can be distinguished from technical work.
Components: Internals>Services

Comment 173 by jam@chromium.org, Nov 10 2017

Blockedon: 783981

Comment 174 by jam@chromium.org, Nov 13 2017

Blockedon: 784576
Project Member

Comment 175 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e634d9e791f279359915d1ebd7b76b9a09375bb9

commit e634d9e791f279359915d1ebd7b76b9a09375bb9
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Nov 13 22:29:20 2017

Annotate more browser_tests failures with network service.

BUG=598073
TBR=yzshen@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibbafcf79f7bf10d1b96f252c94f1b90ec668cf6d
Reviewed-on: https://chromium-review.googlesource.com/767025
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516080}
[modify] https://crrev.com/e634d9e791f279359915d1ebd7b76b9a09375bb9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 176 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18498ddacc6594ad6367fb74bd7a5918301cc1e2

commit 18498ddacc6594ad6367fb74bd7a5918301cc1e2
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Nov 14 02:28:23 2017

More updates to network service browser_tests filter file after r516080

BUG=598073
TBR=yzshen@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6008e29f84337de9da48cbb8b1152f521107292d
Reviewed-on: https://chromium-review.googlesource.com/768096
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516150}
[modify] https://crrev.com/18498ddacc6594ad6367fb74bd7a5918301cc1e2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 177 by jam@chromium.org, Nov 15 2017

Blockedon: 785420
Blockedon: 787619

Comment 179 by jam@chromium.org, Nov 22 2017

Blockedon: 787891
Blockedon: 789632
Blockedon: 789636
Blockedon: 789640
Blockedon: 789644
Blockedon: 789657
Blockedon: 746977
Blockedon: 789670
Blockedon: 789673
Project Member

Comment 188 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32

commit 8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Dec 04 23:23:20 2017

Add a feature flag to run network service in-process.

This helps with debugging.

Bug: 598073
Change-Id: I72d92c5b4870e4b1e985ae1a2442980b08dbe34c
Reviewed-on: https://chromium-review.googlesource.com/806800
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521502}
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/chrome/browser/about_flags.cc
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/components/network_session_configurator/common/BUILD.gn
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/components/network_session_configurator/common/network_features.h
[add] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/components/network_session_configurator/common/network_session_configurator_export.h
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/components/network_session_configurator/common/network_switches.h
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/content/public/common/content_features.cc
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/content/public/common/content_features.h
[modify] https://crrev.com/8067cc0f4a81a3b5c4ca3fe6014481e7b78ade32/tools/metrics/histograms/enums.xml

Comment 189 by jam@chromium.org, Dec 13 2017

Blockedon: 753658

Comment 190 by jam@chromium.org, Dec 20 2017

Blockedon: 796596
Blockedon: 797292

Comment 192 by jam@chromium.org, Dec 28 2017

Blockedon: 798010

Comment 193 by jam@chromium.org, Jan 10 2018

Blockedon: 792546

Comment 194 by jam@chromium.org, Jan 17 2018

Blockedon: 803125

Comment 195 by jam@chromium.org, Jan 17 2018

Blockedon: 803149
Blockedon: 803452

Comment 197 by jam@chromium.org, Jan 18 2018

Blockedon: 803671
Blockedon: 803958
Blockedon: 810329
Blockedon: 805986
Blockedon: 810555
Blockedon: 810950
Cc: -rdsmith@chromium.org
Blockedon: 817134
Blockedon: 819244

Comment 206 by jam@chromium.org, Mar 12 2018

Blockedon: 820996
Blockedon: 822415
Blockedon: 822484

Comment 209 by jam@chromium.org, Mar 22 2018

Blockedon: 824783
Blockedon: 824967
Blockedon: 824970
Blockedon: 824997
Blockedon: 824974
Blockedon: 825242
Blockedon: 826780
Project Member

Comment 216 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f520a8495ee33d9e4be72be42adab8efd0b96dd

commit 7f520a8495ee33d9e4be72be42adab8efd0b96dd
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Mar 28 21:38:37 2018

Add a note to URLFetcher that it shouldn't be use in content embedders.

Also add a presubmit warning to trigger on new/modified uses of
URLFetcher.

Bug:  746977 , 598073
Change-Id: I962a9f9bdb0c8c533f5cc4e7ca5a919f917a89ca
Reviewed-on: https://chromium-review.googlesource.com/984512
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546605}
[modify] https://crrev.com/7f520a8495ee33d9e4be72be42adab8efd0b96dd/PRESUBMIT.py
[modify] https://crrev.com/7f520a8495ee33d9e4be72be42adab8efd0b96dd/net/url_request/url_fetcher.h

Comment 217 by jam@chromium.org, Mar 30 2018

Blockedon: 827531

Comment 218 by jam@chromium.org, Mar 30 2018

Blockedon: 827532
Project Member

Comment 219 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59716d015d9d4a7870990a83419d7b5c3806a213

commit 59716d015d9d4a7870990a83419d7b5c3806a213
Author: Matt Menke <mmenke@chromium.org>
Date: Thu Apr 05 12:45:53 2018

Make the net::URLFetcher presubmit check not require a presubmit bypass

I misunderstood the boolean parameter. This check is intended to be
advisory, rather than something that blocks landing CLs.

Bug:  746977 , 598073
Change-Id: Ib7695f7bea15f1613a4f9e73e0258fa231340161
Reviewed-on: https://chromium-review.googlesource.com/992393
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548394}
[modify] https://crrev.com/59716d015d9d4a7870990a83419d7b5c3806a213/PRESUBMIT.py

Blockedon: 835429
Blockedon: 837333
Blockedon: 820060
Blockedon: 838906
Blockedon: 838910
Project Member

Comment 225 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b7d02f22b70c27f32fa5508f785ba310d08aad3

commit 4b7d02f22b70c27f32fa5508f785ba310d08aad3
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu May 03 17:46:35 2018

Don't instantiate ChromeNetworkDelegate when network service is enabled.

Bug: 598073

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I59722f8aa6c1946c3f2cf00bbbad0d8c96e0d12f
Reviewed-on: https://chromium-review.googlesource.com/1041486
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555800}
[modify] https://crrev.com/4b7d02f22b70c27f32fa5508f785ba310d08aad3/chrome/browser/io_thread.cc
[modify] https://crrev.com/4b7d02f22b70c27f32fa5508f785ba310d08aad3/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/4b7d02f22b70c27f32fa5508f785ba310d08aad3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Blockedon: 840359
Blockedon: 840378
Blockedon: 840444

Comment 230 by jam@chromium.org, May 8 2018

Blockedon: 840600
Project Member

Comment 231 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43db2f0f70498802a6b9a12a0a9fdc4fecd97aaf

commit 43db2f0f70498802a6b9a12a0a9fdc4fecd97aaf
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue May 08 18:08:09 2018

Fix WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement flake on Windows with network service.

This passes all the time on Linux with network service, but fails most of the time on Windows. The problem is that due to timing differences with network service, |webview| is torn down while it still has its navigation in-progress. WebViewGuest::DidFinishNavigation then synthesizes a LoadAbort called and (I'm not sure why) onNewWindow gets called a second time.

Bug: 598073
Change-Id: I7ca2acd5e4ec7ddbfc25f94184d83e1abdb25545
Reviewed-on: https://chromium-review.googlesource.com/1049011
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556876}
[modify] https://crrev.com/43db2f0f70498802a6b9a12a0a9fdc4fecd97aaf/chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

Comment 232 by jam@chromium.org, May 8 2018

Blockedon: 841039
Blockedon: -822484
Blockedon: 841526
Blockedon: 821021
Blockedon: 821027
Blockedon: 837354
Blockedon: 841445
Blockedon: 838949

Comment 240 by jam@chromium.org, May 9 2018

Blockedon: 841556

Comment 241 by jam@chromium.org, May 16 2018

Blocking: 824840

Comment 242 by jam@chromium.org, May 16 2018

Blocking: 824843

Comment 243 by jam@chromium.org, May 16 2018

Blocking: 824858

Comment 244 by jam@chromium.org, May 16 2018

Blocking: 824856

Comment 245 by jam@chromium.org, May 16 2018

Blocking: 824854

Comment 246 by jam@chromium.org, May 16 2018

Blocking: 824845

Comment 247 by jam@chromium.org, May 16 2018

Blocking: 824844

Comment 248 by jam@chromium.org, May 22 2018

Blockedon: 845612

Comment 249 by dxie@chromium.org, May 22 2018

Labels: Hotlist-KnownIssue
Blocking: 846167

Comment 251 by jam@chromium.org, May 30 2018

Blockedon: 847866
Blockedon: 848801
Blockedon: 857165
//NOLAUNCH - We are keeping this to the canary channel only in M70 and will not go beyond that. We will create a separate launch bug when if we decide to go beta in M71. 
Blockedon: 876836
Blockedon: 877992
Blockedon: 877996
Blockedon: -877992
Blocking: 705114
Blockedon: -705114
Blockedon: 892363
Blockedon: 898306
Blockedon: 904910
Blockedon: 920727
Showing comments 165 - 264 of 264 Older

Sign in to add a comment