New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598058 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

AVDA and GVD can get out of sync with which bitstream buffers AVDA owns

Project Member Reported by w...@chromium.org, Mar 25 2016

Issue description

In AVDA::QueueInput it's possible to pop a pending bitstream buffer and then return with a failure without NotifyEndOfBitstreamBuffer. If the AVDA is Reset before the error is propogated to GVD, now GVD and AVDA are out of sync.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3aaff8dbedaf7ce7fdfeb6fde7031486e485408

commit c3aaff8dbedaf7ce7fdfeb6fde7031486e485408
Author: watk <watk@chromium.org>
Date: Tue Mar 29 21:39:08 2016

media: AVDA now always notifies GVD of consumed bitstream buffers

In AVDA::QueueInput it was possible that a pending bitstream buffer was
popped from the queue but then a failure caused it to return without
NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was
propogated to GVD, GVD and AVDA became out of sync.

Now the bitstream buffer notification is done regardless of whether
an error occurred.

BUG= 598058 

Review URL: https://codereview.chromium.org/1831323002

Cr-Commit-Position: refs/heads/master@{#383836}

[modify] https://crrev.com/c3aaff8dbedaf7ce7fdfeb6fde7031486e485408/content/common/gpu/media/android_video_decode_accelerator.cc

Comment 2 by w...@chromium.org, Mar 29 2016

Components: Internals>Media>Hardware
Labels: Merge-Request-50

Comment 3 by tin...@google.com, Mar 29 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd2bede866bee839251d2e7659022e885b54d928

commit bd2bede866bee839251d2e7659022e885b54d928
Author: Chris Watkins <watk@chromium.org>
Date: Wed Mar 30 20:34:43 2016

media: AVDA now always notifies GVD of consumed bitstream buffers

In AVDA::QueueInput it was possible that a pending bitstream buffer was
popped from the queue but then a failure caused it to return without
NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was
propogated to GVD, GVD and AVDA became out of sync.

Now the bitstream buffer notification is done regardless of whether
an error occurred.

BUG= 598058 

Review URL: https://codereview.chromium.org/1831323002

Cr-Commit-Position: refs/heads/master@{#383836}
(cherry picked from commit c3aaff8dbedaf7ce7fdfeb6fde7031486e485408)

Review URL: https://codereview.chromium.org/1843233002 .

Cr-Commit-Position: refs/branch-heads/2661@{#434}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/bd2bede866bee839251d2e7659022e885b54d928/content/common/gpu/media/android_video_decode_accelerator.cc

Comment 5 by w...@chromium.org, Apr 12 2016

Status: Fixed (was: Started)

Sign in to add a comment