New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598053 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 2
Type: Bug



Sign in to add a comment

Don't resize the content view when the keyboard is shown for IME.

Project Member Reported by haibinlu@chromium.org, Mar 25 2016

Issue description

Repo
1. Loads Client and navigates to youtube.com 
2. Search inside youtube.com
3. the typed string shows up inside youtube search textbox after a very long delay.

I suspect that the query text is blocked by other CC messages.


 
Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)
Summary: CC commit 3 times after client shows IME, resulting in very slow search inside youtube.com (was: Search in youtube.com is very very slow)
yup, it is blocked by the full CC commits (3 times!!?) resulting from resizing the Client window when IME is shown.

logs from --vmodule="blimp_message_pump*=2, blimp_engine_session*=2, blimp_connection*=2"


===> Client IME shows, resize to Engine. 
[1291:1310:0325/143735:VERBOSE2:blimp_message_pump.cc(59)] OnReadPacketComplete, result=<BlimpMessage type=TAB_CONTROL subtype=SIZE size=768x466:2.00 byte_size=23>
[1291:1291:0325/143735:VERBOSE1:blimp_engine_session.cc(294)] Resize to 768x466, 2

===> full commit once
[1291:1310:0325/143746:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=1327690>
[1291:1310:0325/143746:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=17>

===> full commit twice??
[1291:1310:0325/143757:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=1325432>
[1291:1310:0325/143757:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=17>

===> full commit 3rd time?
[1291:1310:0325/143808:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=1325432>
[1291:1310:0325/143809:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=17>
[1291:1310:0325/143809:VERBOSE2:blimp_connection.cc(66)] Sender::ProcessMessage <BlimpMessage type=7 target_tab_id=0 byte_size=17>
 

Comment 2 by anandc@chromium.org, Mar 30 2016

Blocking: 597790

Comment 3 by anandc@chromium.org, Mar 31 2016

Blocking: 597791

Comment 4 by anandc@chromium.org, Mar 31 2016

Blocking: -597790

Comment 5 by anandc@chromium.org, Mar 31 2016

Blocking: -597791
Blocking: 597789
Components: Mobile>Blimp>Client
Labels: M-52 OS-Android
Cc: nyquist@chromium.org khushals...@chromium.org
Summary: Don't resize the content view when the keyboard is shown for IME. (was: CC commit 3 times after client shows IME, resulting in very slow search inside youtube.com )
The commits are expected since the engine requests them, as discussed in crbug/598082. We should not resize when the IME is shown to avoid a re-layout.
Labels: Blimp-M52-Proj-Scope
[Bulk edit]

This Blimp bug is targeted to M-52, which ends today.  Please change the target milestone to M-53 (which ends June 30) if appropriate and if your team lead signs off.  Any items still targeted to M-52 on Monday will have their milestone tags removed.

Please do *not* remove the label Blimp-M52-Proj-Scope if it exists on this bug; that is a scope tracking label only.  Similarly, do not add Blimp-M53-Proj-Scope yet either; I'll take care of that.

Ping me with any questions, thanks!
shaktisahu@ will ping bruno about this to ensure that we have a clear path forward from a UX perspective.

Comment 11 by w...@chromium.org, May 24 2016

Labels: -M-52 M-53
Shakti, are you intending to resolve this, or should we WontFix pending the client-integration work completing?
Labels: -M-53
Shakti will ping Bruno first, and then we'll see what he says about at least finding a way for how we want this to behave. Based on that we should know more on how this would be affected in the integration with Chrome.
Labels: M-53
Blocking: -597789
Labels: -M-53 M-54
For now resizes the content area when entering text in a webpage.  Will push the more comprehensive fix of not doing a full round trip resize until later.
Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.
Status: WontFix (was: Assigned)
Closing this out.  We're going to move the IME to a popup for now to start to get a feel for how that works and also to bypass the resize issues until we actually want/need to fix them.
Labels: -M-54 M-55
Status: Assigned (was: WontFix)
Actually even with the popup we don't want to resize the content.  But I don't think we care about keeping the text box on the page with that UI.  Moving to M-55 though.
Status: Fixed (was: Assigned)
Fixed with popup. There is no more need to resize the content.
CL : https://codereview.chromium.org/2292343002/
Labels: Archive-Blimp

Sign in to add a comment