Issue metadata
Sign in to add a comment
|
Address bar not updated when returning from network error page. |
||||||||||||||||||||
Issue descriptionApp Version: 51.0.2690.0 canary iOS Version: 9.2.1, 9.3 Device: iPhone6s URL: http://output.jsbin.com/fozaqiceve This bug a little variant from previously reported http://crbug/597068 Steps to reproduce: 1. Launch Google Chrome canary 2. Goto the above URL (http://output.jsbin.com/fozaqiceve) 3. Tap on "Run test case" 4. Observe that network error page is displayed. 5. Tap on "Back to safety" Observed results: Observe that url is still showing "https://tv.eurosport.com" Expected results: URL should be updated to about:blank on tapping "Back to Safety" Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Dolphin/Safari/Firefox: Firefox: No, Safari: NO (Safari shows alert to continue/cancel, FF shows Error page and no option to Back) Bug reproducible on current stable build (App Version, iOS Version): M49 YES Bug reproducible on the current beta channel build (App Version, iOS Version): M50 YES Link to video/image: https://drive.google.com/a/google.com/file/d/0B-xmXLQhjeKuVVBlOE5qUGZ0ZjA/preview
,
Mar 28 2016
JSBin output expired after few days, so moved test case URL to below: http://blingtestapp.appspot.com/eurosport.html
,
Apr 1 2016
We should include this into M50 respin, but it's too late to include into regular release as the change is risky. CL1: https://chromereviews.googleplex.com/393757013/ CL2: https://codereview.chromium.org/1844363004/
,
Apr 1 2016
,
Apr 2 2016
This bug has impact on security as it allows spoofing *any* URL during MITM attack. SSL lock will be red and broken, but many users don't care about lock color. The fix is risky because web// has never signaled *did finish load* for cases when reload happened with Empty Navigation Manager. So the change can potentially introduce the new crashes. I would be comfortable merging this to the branch only if the changes live on Canary for let's say a week. This is why I proposed to include the changes in respin. Chris, how bad is this bug? Can this wait until M51?
,
Apr 4 2016
I'd rather not wait, this is a pretty troubling Omnibox spoof, and changes the apparent meaning of "Back To Safety". +felt to see if she agrees with the labels.
,
Apr 4 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/4e709c3b7a1ebc7545725425ea088981f88cd4d0 commit 4e709c3b7a1ebc7545725425ea088981f88cd4d0 Author: eugenebut <eugenebut@google.com> Date: Mon Apr 04 22:26:10 2016
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8466be358c11657cb90fe148c10017573e6cabdc commit 8466be358c11657cb90fe148c10017573e6cabdc Author: eugenebut <eugenebut@chromium.org> Date: Tue Apr 05 02:15:59 2016 [ios] Signal DidFinishLoad if target URL is invalid. Target URL can be invalid if Reload is called for empty navigation manager. Empty Navigation Manager is a reasonable state when the only pending item was a page with badd SSL cert and user Tapped Go Back. BUG= 598047 Review URL: https://codereview.chromium.org/1844363004 Cr-Commit-Position: refs/heads/master@{#385085} [modify] https://crrev.com/8466be358c11657cb90fe148c10017573e6cabdc/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 5 2016
,
Apr 5 2016
[Automated comment] Less than 2 weeks to go before AppStore submit on M50, manual review required.
,
Apr 5 2016
Verified on iPhone6s, iPad Air2 with M51.0.2701.0 canary. Tapping on "Back to Safety" redirects correctly to about:blank page. (document.write works/allowed on about:blank) eugenebut@ you mentioned about potential new crashes with this change in comment#5. Please let us know if we need to run any regression tests, and if so, then what would be the areas need tobe focused on.
,
Apr 5 2016
>> eugenebut@ you mentioned about potential new crashes with this change in comment#5. Please let us know if we need to run any regression tests, and if so, then what would be the areas need tobe focused on. Prerequisite for the crashes can be following STR from this bug.
,
Apr 5 2016
Let's cherrypick this and monitor the next beta release for crashes that could be caused by this change.
,
Apr 5 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/382aab43feab834896fe50a6c25b4947356fdc43 commit 382aab43feab834896fe50a6c25b4947356fdc43 Author: eugenebut <eugenebut@google.com> Date: Mon Apr 04 22:26:10 2016
,
Apr 5 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/382aab43feab834896fe50a6c25b4947356fdc43 commit 382aab43feab834896fe50a6c25b4947356fdc43 Author: eugenebut <eugenebut@google.com> Date: Mon Apr 04 22:26:10 2016
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b527df8f6c0fe8da64f67b58143ee34c4e6133be commit b527df8f6c0fe8da64f67b58143ee34c4e6133be Author: Eugene But <eugenebut@google.com> Date: Tue Apr 05 21:46:18 2016 [ios] Signal DidFinishLoad if target URL is invalid. Target URL can be invalid if Reload is called for empty navigation manager. Empty Navigation Manager is a reasonable state when the only pending item was a page with badd SSL cert and user Tapped Go Back. BUG= 598047 Review URL: https://codereview.chromium.org/1844363004 Cr-Commit-Position: refs/heads/master@{#385085} (cherry picked from commit 8466be358c11657cb90fe148c10017573e6cabdc) Review URL: https://codereview.chromium.org/1864783002 . Cr-Commit-Position: refs/branch-heads/2661@{#497} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/b527df8f6c0fe8da64f67b58143ee34c4e6133be/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 6 2016
,
Apr 12 2016
,
Apr 12 2016
,
Jun 21 2016
,
Jul 13 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2016
Verified on M51,52 and M53 Chrome. Device: iPhone6, iPhone5 iOS: 9.3.2, 10.0
,
Oct 1 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by eugene...@chromium.org
, Mar 25 2016