New issue
Advanced search Search tips

Issue 598042 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

[People - CROS only] Update 'manage other people' subpage to spec

Project Member Reported by bettes@chromium.org, Mar 25 2016

Issue description

Comment 1 by bettes@chromium.org, Mar 25 2016

Cc: bettes@chromium.org
Thanks. I'm shocked that subpage works at all. I will address these deficiencies.
Labels: Hotlist-MD-Settings-PeopleCrOS
Cc: tommycli@chromium.org
Owner: mahmadi@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af59c5177d3a4012d39e3ea1471ab865b309f9fe

commit af59c5177d3a4012d39e3ea1471ab865b309f9fe
Author: mahmadi <mahmadi@chromium.org>
Date: Tue Nov 15 23:26:48 2016

[MD settings][cros accounts] Updates the accounts page according to the specs

BUG= 598042 ,  563928 

1. checkbox unchecked state:
https://screenshot.googleplex.com/dkZsoRT2TFx
2. checkbox checked state:
https://screenshot.googleplex.com/Qt4JzHLWQnN

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2495933002
Cr-Commit-Position: refs/heads/master@{#432287}

[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/app/settings_strings.grdp
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/resources/settings/people_page/user_list.js
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/resources/settings/people_page/users_page.js
[modify] https://crrev.com/af59c5177d3a4012d39e3ea1471ab865b309f9fe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment