New issue
Advanced search Search tips

Issue 598039 link

Starred by 2 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add SocketWatcherFactory as a helper class to NetworkQualityEstimator

Project Member Reported by tbansal@chromium.org, Mar 25 2016 
Add SocketWatcherFactory (SWF) as a helper class to NetworkQualityEstimator (NQE). NQE should own SWF, and provide it with a task runner. SWF should implement SocketPerformanceWatcherFactory (SPWF), and invoke the NQE callbacks on the provided task runner.

This would ensure that  SocketPerformanceWatcher's that are created on non-IO threads can safely call the provided SPWF.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f56a39a3129c19623e19489d4ed03c9687af586

commit 0f56a39a3129c19623e19489d4ed03c9687af586
Author: tbansal <tbansal@chromium.org>
Date: Thu Apr 07 22:03:38 2016

Add SocketWatcherFactory and SocketWatcher helper classes

NQE::SocketWatcherFactory implements
SocketPerformanceWatcherFactory (SPWF).

NQE::SocketWatcher implements SocketPerformanceWatcher
(SPW), and notifies NQE on the provided task runner. This
also removes the cyclic dependency between SPW and SPWF.

BUG= 590265 , 598039 

Review URL: https://codereview.chromium.org/1831383002

Cr-Commit-Position: refs/heads/master@{#385891}

[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/chrome/browser/android/net/external_estimate_provider_android_unittest.cc
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/net/base/network_quality_estimator.cc
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/net/base/network_quality_estimator.h
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/net/base/network_quality_estimator_unittest.cc
[delete] https://crrev.com/41f8478faaf6c41b2b484e167b3dbb6a95674839/net/base/socket_performance_watcher.cc
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/net/base/socket_performance_watcher.h
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/net/base/socket_performance_watcher_factory.h
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/net/net.gypi
[modify] https://crrev.com/0f56a39a3129c19623e19489d4ed03c9687af586/net/quic/quic_network_transaction_unittest.cc

Comment 2 by tbansal@chromium.org, Apr 8 2016

Status: Fixed (was: Started)

Comment 3 by tbansal@chromium.org, Feb 14 2017

Components: Internals>Network>NetworkQuality
►

Sign in to add a comment