New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 598032 link

Starred by 5 users
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Placing breakpoints on lines of source-mapped code places the breakpoint elsewhere

Reported by k...@doddsfamily.us, Mar 25 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36

Steps to reproduce the problem:
See this gif: http://cl.ly/3b0b0Q0v1l3p
And this one: http://cl.ly/1Q2i2J0a1k0U

What is the expected behavior?
I expect that when I click to apply a breakpoint to a line, that the breakpoint is placed on that line.

What went wrong?
I believe that there's an issue with the breakpoints UI not taking sourcemaps into consideration.

Did this work before? No 

Chrome version: 49.0.2623.87  Channel: stable
OS Version: OS X 10.10.5
Flash Version: Shockwave Flash 21.0 r0

Comment 1 by kozyatinskiy@chromium.org, Mar 29 2016

Labels: Needs-Feedback
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)
Thank you for report!
This issue is related to source map. We try to set breakpoint in current line but this line is mapped to line without JS or with JS where we couldn't set breakpoint and we try to set breakpoint in next line.
I can debug this case if you can provide sourcemap and source file.

Comment 2 by k...@doddsfamily.us, Mar 30 2016 

Here's an isolated example: https://github.com/kentcdodds/bug-source-maps

See the live page here: https://cdn.rawgit.com/kentcdodds/bug-source-maps/master/index.html

Let me know if you have any questions.

Comment 3 by kozyatinskiy@chromium.org, Apr 11 2016

Status: Fixed (was: Assigned)
Thank you!
I can reproduce issue in current stable but it works in current ToT. It looks like fixed. You can check it in current Canary build.

Comment 4 by k...@doddsfamily.us, Apr 11 2016 

Fantastic! I've updated the repo with an gif indicating that it's been fixed! Thanks for fixing this so quickly!
►

Sign in to add a comment