Reduce priority of long-running GPU tests |
||
Issue descriptionNow that Issue 582625 has been fixed, there is the ability to specify a priority adjustment for Swarming jobs. I think it would make sense to down-weight the long-running dEQP tests as has been discussed previously offline. The rough syntax in the src/testing/buildbot JSON files is: 'Linux Tests': { 'gtest_tests': [ { 'test': 'gl_tests', 'swarming': { 'can_use_on_swarming_builders': True, 'priority_adjustment': 'higher', 'expiration': 7200, }, }, ], }, In order to effect a priority adjustment for the dEQP tests, support needs to be added to src/content/test/gpu/generate_buildbot_json.py so that the angle_deqp_gles2_tests and angle_deqp_gles3_tests can specify both a lower priority and a higher timeout.
,
Mar 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11bb0a6c64122c7fe3eca9922f620299ac073016 commit 11bb0a6c64122c7fe3eca9922f620299ac073016 Author: cwallez <cwallez@chromium.org> Date: Mon Mar 28 20:12:12 2016 Reduce swarming priority of the ANGLE dEQP tests. BUG= 598010 Review URL: https://codereview.chromium.org/1837653002 Cr-Commit-Position: refs/heads/master@{#383549} [modify] https://crrev.com/11bb0a6c64122c7fe3eca9922f620299ac073016/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/11bb0a6c64122c7fe3eca9922f620299ac073016/testing/buildbot/chromium.gpu.fyi.json
,
Mar 29 2016
Ken, are there other tests that would require this priority adjustment?
,
Mar 29 2016
The dEQP tests were the primary ones.
,
Mar 29 2016
Since this patch landed I haven't noticed big changes in the bots behavior (dEQP shard run time on a sample of one shard went from 4.5 minutes to 5.5 minutes). Closing this issue.
,
Mar 29 2016
Awesome. Thanks for fixing this and following up.
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99c15188deae7f59aa467196b0d1c90a62855cd2 commit 99c15188deae7f59aa467196b0d1c90a62855cd2 Author: cwallez <cwallez@google.com> Date: Fri May 20 02:34:07 2016 Reset the swarming priority of the ANGLE dEQP tests With reduced swarming, the ANGLE dEQP tests time out sometimes. We noticed it happening for example when many ANGLE tryjobs are sent. This partially reverts 11bb0a6c64122c7fe3eca9922f620299ac073016 BUG= 598010 BUG= 601460 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/1996153002 Cr-Commit-Position: refs/heads/master@{#394961} [modify] https://crrev.com/99c15188deae7f59aa467196b0d1c90a62855cd2/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/99c15188deae7f59aa467196b0d1c90a62855cd2/testing/buildbot/chromium.gpu.fyi.json |
||
►
Sign in to add a comment |
||
Comment 1 by cwallez@chromium.org
, Mar 25 2016Status: Assigned (was: Untriaged)