New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598002 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 2
Type: Bug



Sign in to add a comment

Add plumbing for SSLKEYLOGFILE in Cronet

Project Member Reported by xunji...@chromium.org, Mar 25 2016

Issue description

Being able to set SSLKEYLOGFILE in Cronet will be helpful to analyze packets data using wireshark. See more info at https://www.imperialviolet.org/2012/06/25/wireshark.html.

This probably can be done using the static function:
SSLClientSocket::SetSSLKeyLogFile (see https://codereview.chromium.org/1403863002). Need necessary plumbing to pass the variable from Java to net.

 

Comment 1 by mef@chromium.org, Mar 25 2016

Cc: davidben@chromium.org
I think we can add "ssl_keylog_file_path" to CronetEngine experimental options.
Cc: juberti@chromium.org
Owner: xunji...@chromium.org
Status: Started (was: Available)
I don't think anyone else has any cycle. I will give it a try.
Labels: OS-Android
Thanks. I can try this weekend if you don't get to it first. 

Do we want experimental option or a real API? Don't care much for the short term, but want to make sure we don't end up with a bunch of hidden APIs and this seems like something we would probably want for the long term. 
Labels: OS-iOS
Talked to davidben@, QUIC has its own crypto stack, so SSLKeyLogFile won't be applicable there. This will only be useful for HTTP/2 traffic.

I will have a CL out for review shortly. Will keep this as an experimental API for now. 


Hmm... we need the QUIC logging more than anything else. How does QUIC key dumping currently work?
I followed up on the email thread.
On when to expose this as a stable API, we will need to wait until crbug.com/458365 is resolved. Setting SSLKEYLOGFILE isn't safe to do with multiple CronetEngines right now.
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Started)
Android side is done. Misha is working on iOS so I will leave this bug open. Again since this doesn't cover QUIC, so I will lower the priority to P2. Please re-adjust if needed.

Comment 12 by mef@chromium.org, Apr 26 2016

Owner: mef@chromium.org
Status: Assigned (was: Available)
mef@ will verify that its available on iOS.

Comment 13 by mef@chromium.org, Apr 26 2016

Status: Fixed (was: Assigned)
The iOS support was added as part of initial implementation of Cronet for iOS with C API for GRPC support: https://chromium.googlesource.com/chromium/src/+/06eab3e8e64eacef30f15299ee7c3ad32df2840b

Sign in to add a comment