New issue
Advanced search Search tips

Issue 598000 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Apply a few more locale fixes to ICU (post 56.1)

Project Member Reported by js...@chromium.org, Mar 25 2016

Issue description

There are a few important updates for ICU 56.1's locale data. The easiest way to test is to use JS console in Chrome's DOM inspector  (or v8's d8 shell). 

1. en-AU date format is incorrect. 

d8> (new Date(0)).toLocaleString("en-AU", {month: "long", year: "numeric", day: "numeric"})

Expected: "31 December 1969" 
Current: "31December1969"


2. Turkish Lira sign (U+20BA) is not used in Turkish locale while it's used in other locales !. 

d8> (new Number(12345)).toLocaleString("tr", {currency: "TRY", style:"currency"})

Expected: "12.345,00 ₺<U+20BA>"   (U+20BA is not shown in Mac Chrome in some cases (even though I do have a font for that) so that I'm using "<U+20BA>" here. 

Current: "12.345,00 TL"

3. IANA tz db update to 2016c from 2016a.
What's new in 2016b and 2016c are found at

http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b)
http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c)

Changes were made for Chile, Azerbaijan, and several timezones in Russia. We may have to update tz db in branches as well because they affect DST rule changes in March. 


 

Comment 1 by js...@chromium.org, Mar 25 2016

d8> d20160622 = new Date("2016-06-22T00:00Z")
Tue Jun 21 2016 17:00:00 GMT-0700 (PDT)
d8> d20160622.toLocaleString("en-US", {timeZone: "Asia/Baku"})
Expected: "6/22/2016, 4:00:00 AM"
Actual: "6/22/2016, 5:00:00 AM"

d8> d20160622.toLocaleString("en-US", {timeZone: "America/Santiago"})
Expected: "6/21/2016, 8:00:00 PM"
Actual: "6/21/2016, 9:00:00 PM"

d8> d20160328 = new Date("2016-03-28T00:00Z")
Sun Mar 27 2016 17:00:00 GMT-0700 (PDT)
d8> d20160328.toLocaleString("en-US", {timeZone: "Asia/Sakhalin"})
Expected: "3/28/2016, 11:00:00 AM"
Actual: "3/28/2016, 10:00:00 AM"

d8> d20160326 = new Date("2016-03-26T00:00Z")
Fri Mar 25 2016 17:00:00 GMT-0700 (PDT)
d8> d20160326.toLocaleString("en-US", {timeZone: "Asia/Sakhalin"})
Both expected and actual: "3/26/2016, 10:00:00 AM"

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/icu.git/+/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471

commit 3edd83a9c607c7dc0c0fd34d68057da5c4d0f471
Author: Jungshik Shin <jshin@chromium.org>
Date: Fri Mar 25 23:33:42 2016

Update timezone DB and apply miscellaneous locale data fixes

1. Update the IANA tz data to 2016c

What's new in 2016b and 2016c are found at

  http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b)
  http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c)

2. Locale data fixes
  - en-AU date format fix from the upstream
  - ar and fa: Prepend 'percent sign' with RTL mark (U+200F). From Android.
  - tr: Use ₺ (U+20BA; Turkish Lira Sign) instead of 'TL'. This is to revert a locale patch picked up from Google's internal build of ICU. (Android also uses U+20BA).

In addition, icudtl.dat (the prebuilt ICU data file for platforms other than
Android is moved out of source/data/in to common/. This way, the data build
steps for non-Android and Android can be unified and a bit more streamlined.
icu.gyp and BUILD.gn are updated accordingly as well as README.chromium.

BUG= 598000 
TEST=See bug comment 0 and comment 1
R=mark@chromium.org

Review URL: https://codereview.chromium.org/1823293002 .

[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/BUILD.gn
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/README.chromium
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/android/icudtl.dat
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/android/icudtl_dat.S
[rename] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/common/icudtl.dat
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/icu.gyp
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/linux/icudtl_dat.S
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/mac/icudtl_dat.S
[add] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/patches/locale_extra.patch
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/patches/locale_google.patch
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/patches/remove_si.patch
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/scripts/copy_data.sh
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/curr/tr.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/locales/ar.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/locales/en_AU.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/locales/fa.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/misc/metaZones.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/misc/timezoneTypes.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/misc/windowsZones.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/source/data/misc/zoneinfo64.txt
[modify] https://crrev.com/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471/windows/icudt.dll

Comment 5 by js...@chromium.org, Apr 2 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cca67e56b2a1681af5d71e0648dec0b48eed194c

commit cca67e56b2a1681af5d71e0648dec0b48eed194c
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Mar 06 00:32:53 2018

Android: Get rid of ContentViewCore.getViewportWidth/HeightPix

The 2 remaining callsites can use the corresponding content view
directly to get the physical width/height. This CL does that, and removes
the interfaces from ContentViewCore.

Bug:  598000 
Change-Id: I29a15a85eae58ded74dcbd6b00b8ba35f49c94fa
Reviewed-on: https://chromium-review.googlesource.com/945185
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541004}
[modify] https://crrev.com/cca67e56b2a1681af5d71e0648dec0b48eed194c/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/cca67e56b2a1681af5d71e0648dec0b48eed194c/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestFramework.java
[modify] https://crrev.com/cca67e56b2a1681af5d71e0648dec0b48eed194c/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
[modify] https://crrev.com/cca67e56b2a1681af5d71e0648dec0b48eed194c/content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java
[modify] https://crrev.com/cca67e56b2a1681af5d71e0648dec0b48eed194c/content/public/android/java/src/org/chromium/content_public/browser/ContentViewCore.java
[modify] https://crrev.com/cca67e56b2a1681af5d71e0648dec0b48eed194c/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewCore.java

Sign in to add a comment