One of the build phases should verify we have appropriate debug symbols (including Chrome) |
|||||
Issue descriptionThis is a follow on to https://bugs.chromium.org/p/chromium/issues/detail?id=595763 where debug symbols had to be disabled to get the Chrome image down to a reasonable size. It was noted that Goldeneye reports the debug symbols have passed for the builds that had debug symbols removed from Chrome by https://chromium-review.googlesource.com/#/c/334295/ This seems to be rooted in the DebugSymbols build phase passing in these builds, which looks right. What we would like to see here is some sort of reporting that the build does not have sufficient debug symbols for release within Chrome, not sure if that is a modification to the DebugSymbols phase, a new phase, or some other probing mechanism from Goldeneye, any ideas?
,
Mar 25 2016
,
Mar 25 2016
If it is not actionable that is fine, I just wanted to check if there was anything we could do, do you think this is WontFix? Essentially from a release perspective it will be handy to have an indication that we have a 'release blocking' level of symbols missing if that is possible.
,
Mar 25 2016
Agree with ihf.. verifying a complete set is not a simple task... How often is this a problem. I think it is the first time I heard that we are putting incomplete symbols into the image.
,
Mar 25 2016
I think this is not all that common, there was initially a misunderstanding that the DebugSteps stage does this which brought up the concern. We also almost pushed a Dev that was missing symbols. This sounds like a WontFix here.
,
Mar 28 2016
we've had this question come up now & then in the past, and we've yet been able to really qualify what "passing" means in any reasonable/programmatic way, so we've just kept with the current setup -- dump_syms didn't crash, and the debug symbols stage is green.
,
Apr 27 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ihf@chromium.org
, Mar 25 2016