New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597991 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Avoid reboot the device after configuration changed

Project Member Reported by ntang@google.com, Mar 25 2016

Issue description

Current behavior, we have to reboot the device when configuration changed.

To be less intrusive, we may need to find a way without reboot, or only restart apache, or no restart at all.
 

Comment 1 by ntang@google.com, Mar 25 2016

Cc: autumn@chromium.org jean@chromium.org
My speculation is, because python wsgi_mod with multiple processes does not support "singleton" object. So reloading configuration in one process does not help to update the configuration. Needs smarter reloading mechanism.

Comment 2 by ntang@google.com, May 24 2016

we will add "expect fork" in the apache upstart script. Then we could restart apache by using "sudo restart moblab-apache-init".
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d1849b20ae6542b2938491596bc9fba46b2f99b3

commit d1849b20ae6542b2938491596bc9fba46b2f99b3
Author: Michael Tang <ntang@google.com>
Date: Tue May 24 06:01:49 2016

Fix the apache upstart forking.

The apache2 command forks child process and exits. The upstart script
needs to track the child process intead.

BUG= chromium:597991 
TEST=manually test.

Change-Id: I655917762e85d3602dde5aed736f1fef8393c857
Reviewed-on: https://chromium-review.googlesource.com/347040
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/d1849b20ae6542b2938491596bc9fba46b2f99b3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-apache-init.conf
[rename] https://crrev.com/d1849b20ae6542b2938491596bc9fba46b2f99b3/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r34.ebuild

Project Member

Comment 4 by sheriffbot@chromium.org, Jun 3 2016

Labels: Hotlist-Google

Comment 5 by ntang@google.com, Oct 31 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment