New issue
Advanced search Search tips

Issue 597990 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 597997



Sign in to add a comment

Move web::WebLoadParams to NavigationManager

Project Member Reported by eugene...@chromium.org, Mar 25 2016

Issue description

Move web::WebLoadParams into NavigationManager to parallel NavigationController's LoadURLParams (which web::WebLoadParams is modeled after).
 
Blocking: 597997
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 26 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c8575852158ced6cb92ebc06339ba5f575afa57a

commit c8575852158ced6cb92ebc06339ba5f575afa57a
Author: eugenebut <eugenebut@google.com>
Date: Sat Mar 26 03:10:39 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5543b642720e71d6e15d3f195da85bc87f4946bb

commit 5543b642720e71d6e15d3f195da85bc87f4946bb
Author: eugenebut <eugenebut@google.com>
Date: Mon Mar 28 16:05:04 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e36b109e26e52520d7805136ca3d20d2eea05420

commit e36b109e26e52520d7805136ca3d20d2eea05420
Author: eugenebut <eugenebut@chromium.org>
Date: Mon Mar 28 18:27:23 2016

[ios] Moved WebLoadParams inside NavigationManager.

This matches content's NavigationController::LoadURLParams placement.
After the change navigation_manager.h is now an Objective-C header and
should be imported instead of included.

BUG= 597990 

Review URL: https://codereview.chromium.org/1836793002

Cr-Commit-Position: refs/heads/master@{#383524}

[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/chrome/browser/safe_browsing/safe_browsing_blocking_page.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/chrome/browser/safe_browsing/ui_manager.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/chrome/browser/search/search_util.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/chrome/browser/ssl/ios_chrome_security_state_model_client.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/BUILD.gn
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/interstitials/web_interstitial_impl.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/ios_web.gyp
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/navigation/navigation_manager_impl.h
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/navigation/navigation_manager_impl.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/navigation/web_load_params.h
[delete] https://crrev.com/9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f/ios/web/navigation/web_load_params.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/public/navigation_manager.h
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/public/web_state/ui/crw_web_delegate.h
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/shell/DEPS
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/shell/view_controller.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/2c3e6676133aff6ab1e893b5be9d7ad96b2c8155

commit 2c3e6676133aff6ab1e893b5be9d7ad96b2c8155
Author: eugenebut <eugenebut@google.com>
Date: Thu Mar 31 06:55:17 2016

Status: Fixed (was: Started)

Sign in to add a comment