Sigh. I didn't know this button existed. 

Correct me if I'm wrong but Adding Shortcut means creating a 2nd Chrome icon (badged with your profile) on your desktop and/or task bar? I thought we added secondary Chrome(s) automatically upon creation? 

And to be clear, you're asking for mocks on where the button should live in the 'Edit Person' sub-page? Edit person is not a dialog in MD. 

Deleted: Screen Shot 2016-04-07 at 4.29.51 PM.png 166 KB

	Screen Shot 2016-04-07 at 4.29.51 PM.png 166 KB View Download

Hi, this is for Chrome Browser only. So it's the Edit Person subpage of Chrome Browser (not ChromeOS). I believe this is a Windows-only feature.

Yes, this is to create a 2nd Chrome icon badged with your profile on the desktop. When you create a new user, there is a checkbox to create a desktop shortcut optionally. I've attached the Create Profile dialog (which doesn't exist in MD Settings) to show you the checkbox.

I've also attached the mocks for the current Edit Person subpage for Chrome Browser (which doesn't include the button the old Options Edit Person does).

Deleted: Screenshot from 2016-04-07 17:37:16.png 58.6 KB

	Screenshot from 2016-04-07 17:37:16.png 58.6 KB View Download

Deleted: Screenshot from 2016-04-07 17:35:00.png 50.0 KB

	Screenshot from 2016-04-07 17:35:00.png 50.0 KB View Download

By the way, axing the feature would be okay with me. It's not -incredibly- useful. It's only needed if you:
 - Accidentally unchecked that box when you created the profile.
 - Accidentally deleted the desktop shortcut after you created it.

Also the types of users with multiple profiles can probably just look up how to make their own shortcut... or re-create their profile. The Settings are (potentially) synced to their Google account anyways.

I'll check if we still want this.

Hey Tom,

Any update on this topic? (Potentially axing this feature).

@rpop -- Do you know if this Windows-only feature is still needed? Does it get much usage? It sounds like there will still be a way to create the shortcut when you add a new user to Chrome, so this would just be for people who changed their minds about the shortcut. We'd prefer to remove it to simplify Settings.

 Issue 623523  has been merged into this issue.

@rpop, let us know what you'd like to do!

 Issue 635372  has been merged into this issue.

I chatted offline with Alan and Chris about this today. I do think it's important that we preserve the ability to add a desktop shortcut and don't regress at least for now. Without some type of instrumentation, I'm not comfortable just cutting the feature entirely.

Alan has volunteered to update our mocks for both the user manager "new person" flow and the "edit person" subpage in MD settings to include both the checkbox during profile creation and the button in settings. Once we have those mocks, I'll re-assign to Moe to add them.

We should also add some metrics around the usage of this feature. Maybe a Profile.DesktopShortcutChecked or something, with two buckets to indicate whether or not the checkbox was checked whenever a user creates a new profile?

Tom - does that sound reasonable to you? 

Yes, this sounds reasonable!

 Issue 653988  has been merged into this issue.

Friendly ping for you, Alan. I think it's important that we add this checkbox to MD settings before launching it.

Mocks updated! 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-People-Cros.png%3Fz=width

Deleted: Screen Shot 2016-11-04 at 12.13.29 PM.png 147 KB

	Screen Shot 2016-11-04 at 12.13.29 PM.png 147 KB View Download

Deleted: Screen Shot 2016-11-04 at 12.13.22 PM.png 75.3 KB

	Screen Shot 2016-11-04 at 12.13.22 PM.png 75.3 KB View Download

Thanks Alan! Just to be clear, there are two pieces of UI we need to modify:

(1) Add a "Create a desktop shortcut for this user" checkbox to the "Add person" flow in the new MD user manager.
(2) Add some toggle in the "Edit person" subpage in MD settings to allow users to either remove an existing desktop shortcut or add a new desktop shortcut for an existing profile.

It looks like your mock handles (2), but we still also need (1).

And just to make sure: are we sure that we want the same checkmark UI for (2)? In today's settings page, it's just a button (whose text dynamically changes from "Add desktop shortcut" to "Remove desktop shortcut," depending on if you already have one) - see comment #0 for screenshots.

I personally think the checkmark makes sense during the "Add person" flow, but that a button might make more sense in settings.

Help me...I don't Understand what is going on...why I seing this?...yes,i have sign in with my Google account...

Agreed on using a button when viewing a profile vs checkbox when creating one.

Marking as dev blocker since it is missing functionality.

We chatted offline today, and I think Alan said that we might go with an MD toggle (instead of a button) in the settings page.

Add Person
- use a checkbox, with "Create a desktop shortcut for this user"
- place above the SU checkbox (SU has variable heights)
- 16px between each line

Edit Person
- use a switch (below Name input), with "Show desktop shortcut" 
- use single-line row spec

Deleted: addPerson.png 229 KB

	addPerson.png 229 KB View Download

Deleted: editPerson.png 80.3 KB

	editPerson.png 80.3 KB View Download

Perfect, thanks Alan!

Moe - can you take a look at adding these please?

mahmadi@ or tommycli@: planning on completing this by Thursday for M56 dev?

Sure I'll take over.

@ewald, should we create a shortcut for imported supervised users by default?

#31: Yeah, that seems reasonable.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/528aca2484f31bcf04808c18ab7147eceaf6cc99

commit 528aca2484f31bcf04808c18ab7147eceaf6cc99
Author: mahmadi <mahmadi@chromium.org>
Date: Tue Nov 15 18:28:48 2016

[MD Settings][MD User Manager] create/manage profile desktop shortcut (Windows only)

1. Adds a "Create a desktop shortcut for this user" checkbox to the "Add person" flow in the new MD user manager.
https://screenshot.googleplex.com/m0DJQ7EYaFq

2. Adds a toggle in the "Edit person" subpage in MD settings to allow users to either remove an existing desktop shortcut or add a new desktop shortcut for an existing profile.
https://screenshot.googleplex.com/3EMny94D7z0

BUG= 597984 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2498153002
Cr-Commit-Position: refs/heads/master@{#432218}

[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/app/generated_resources.grd
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/app/settings_strings.grdp
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/resources/md_user_manager/create_profile.js
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/resources/md_user_manager/profile_browser_proxy.js
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/resources/settings/people_page/manage_profile.html
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/resources/settings/people_page/manage_profile.js
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js
[modify] https://crrev.com/528aca2484f31bcf04808c18ab7147eceaf6cc99/chrome/test/data/webui/settings/people_page_manage_profile_test.js

Thanks Moe! Just to double check: the checkbox in the user manager is checked-by-default, correct?

Correct!