Issue metadata
Sign in to add a comment
|
pageAction.hide doesn't work
Reported by
joel.kun...@gmail.com,
Mar 25 2016
|
||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Download and install the Pages2Repo extension https://github.com/Frozenfire92/Pages2Repo or https://chrome.google.com/webstore/detail/pages2repo/afnogakjnebbgcbjkgmhaccljfejeflh (2) Go to a github page http://microsoft.github.io/ for example. Notice extension works as expected when the icon is clicked on. (3) Go to a non github page https://www.google.ca/ for example. Notice extension is still shown (not greyed out) and when clicked has same drop down as right clicking icon What is the expected output? The extension should be greyed out as described here https://groups.google.com/a/chromium.org/d/msg/chromium-extensions/7As9MKhav5E/dNiZDoSCCQAJ What do you see instead? The extension icon in its normal color and clickable to show its right click menu Please provide any additional information below. I have tried adding chrome.pageAction.hide with the correct tabId to the following lines (wrapped in else when necessary) https://github.com/Frozenfire92/Pages2Repo/blob/master/app/scripts/background.js#L54 https://github.com/Frozenfire92/Pages2Repo/blob/master/app/scripts/github.js#L50 https://github.com/Frozenfire92/Pages2Repo/blob/master/app/scripts/github.js#L55 However this does not work and produces the same output as above. I would assume this isn't needed however because the behaviour when in the omnibox was to autohide Originally noted here https://groups.google.com/a/chromium.org/forum/#!topic/chromium-extensions/qdGwH9FbmgU
,
Mar 25 2016
,
Mar 28 2016
,
Mar 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f51a8dcc39fba8b6ce644a54f1ff3814e255b03e commit f51a8dcc39fba8b6ce644a54f1ff3814e255b03e Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Mon Mar 28 22:10:01 2016 [Extensions UI] Tweak the constants for extension action grayscaling The previous grayscaling wasn't enough for extension actions that were mostly black-and-white. Make it a little more noticable. Note that this is still a problem for extension actions that just happen to be gray by default as well as for a11y. :( See crbug.com/597657. BUG= 597981 Review URL: https://codereview.chromium.org/1834293003 Cr-Commit-Position: refs/heads/master@{#383578} [modify] https://crrev.com/f51a8dcc39fba8b6ce644a54f1ff3814e255b03e/chrome/browser/ui/extensions/icon_with_badge_image_source.cc
,
Mar 30 2016
,
Mar 30 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78165fb9893e4064ba964eaf1a1691f48cda31eb commit 78165fb9893e4064ba964eaf1a1691f48cda31eb Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 30 22:27:08 2016 [Extensions UI] Tweak the constants for extension action grayscaling The previous grayscaling wasn't enough for extension actions that were mostly black-and-white. Make it a little more noticable. Note that this is still a problem for extension actions that just happen to be gray by default as well as for a11y. :( See crbug.com/597657. BUG= 597981 Review URL: https://codereview.chromium.org/1834293003 Cr-Commit-Position: refs/heads/master@{#383578} (cherry picked from commit f51a8dcc39fba8b6ce644a54f1ff3814e255b03e) Review URL: https://codereview.chromium.org/1843293002 . Cr-Commit-Position: refs/branch-heads/2661@{#439} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/78165fb9893e4064ba964eaf1a1691f48cda31eb/chrome/browser/ui/extensions/icon_with_badge_image_source.cc |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jrobbins@chromium.org
, Mar 25 2016