New issue
Advanced search Search tips

Issue 597970 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

mash wm shouldn't create widgets

Project Member Reported by sky@chromium.org, Mar 25 2016

Issue description

In an attempt to share code I made the wm create widgets to handle rendering the non-client portion. This leads to lots of awkwardness in the code (NativeWidgetMus has to deal with both cases), and is just confusing. The wm shouldn't create widgets.
 

Comment 1 by sky@chromium.org, Mar 31 2016

Status: WontFix (was: Started)
I poked at this for quite a while. Problem with not creating widgets is that the code for rendering frame decorations wants to use views. That is, it wants to use views for painting, for hover effects, for actions, for updating cursor... It's not terribly complex to get a View to paint outside a widget, but the event dispatching is a bit hairier, and would result in needing to duplicate a fair amount of code (or some refactoring between Widget & RootView).
While the current situation of using Widgets on both ends is mildly confusing, it dramatically simplifies things. So, I'm going to leave it as is and close this out.

Sign in to add a comment