New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597968 link

Starred by 2 users
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: May 2016
Cc:
xhw...@chromium.org
█ roc...@chromium.org
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Rename media::interfaces to media::mojom.

Project Member Reported by xhw...@chromium.org, Mar 25 2016 
Apparently (without documentation), the new recommendation/convention is to use "mojom" module in mojom files. See example: https://codereview.chromium.org/1832813002/

We may consider renaming media::interfaces::Foo to media::mojom::Foo as well. This is not urgent given things keeping change.

Comment 1 by xhw...@chromium.org, Mar 27 2016

Components: -Internals>Media Internals>Media>Mojo

Comment 2 by xhw...@chromium.org, May 13 2016

Labels: OS-All
Owner: jrumm...@chromium.org
jrummell: Could you please help work on this? It should be a straightforward rename.
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ff3de8c91866f203948d36dd74c512fd03839b3

commit 7ff3de8c91866f203948d36dd74c512fd03839b3
Author: jrummell <jrummell@chromium.org>
Date: Tue May 17 18:09:48 2016

Rename media::interfaces to media::mojom.

BUG= 597968 

Review-Url: https://codereview.chromium.org/1977173002
Cr-Commit-Position: refs/heads/master@{#394169}

[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/chrome/browser/chromeos/attestation/platform_verification_impl.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/chrome/browser/chromeos/attestation/platform_verification_impl.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/chrome/browser/media/output_protection_impl.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/chrome/browser/media/output_protection_impl.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/content/browser/media/android/provision_fetcher_impl.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/content/browser/media/android/provision_fetcher_impl.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/content/renderer/media/media_interface_provider.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/content/renderer/media/media_interface_provider.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/base/audio_buffer.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/common/media_type_converters.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/common/media_type_converters.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/common/media_type_converters_unittest.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/common/mojo_shared_buffer_video_frame.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/audio_decoder.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/content_decryption_module.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/decryptor.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/demuxer_stream.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/media_types.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/output_protection.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/platform_verification.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/provision_fetcher.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/renderer.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/interfaces/service_factory.mojom
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/android_mojo_media_client.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/apptest_manifest.json
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/demuxer_stream_provider_shim.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/demuxer_stream_provider_shim.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/media_mojo_unittest.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_audio_decoder.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_audio_decoder.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_audio_decoder_service.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_audio_decoder_service.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_cdm.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_cdm.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_cdm_factory.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_cdm_promise.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_cdm_promise.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_cdm_service.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_decoder_factory.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_decryptor.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_decryptor.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_decryptor_service.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_decryptor_service.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_demuxer_stream_adapter.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_demuxer_stream_adapter.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_demuxer_stream_impl.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_demuxer_stream_impl.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_media_application.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_media_application.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_provision_fetcher.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_provision_fetcher.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_renderer_factory.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_renderer_impl.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_renderer_impl.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_renderer_service.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_renderer_service.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/mojo_video_decoder.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/service_factory_impl.cc
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/service_factory_impl.h
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/mojo/services/test_manifest.json
[modify] https://crrev.com/7ff3de8c91866f203948d36dd74c512fd03839b3/media/test/pipeline_integration_test.cc

Comment 4 by jrumm...@chromium.org, May 17 2016

Status: Fixed (was: Available)
►

Sign in to add a comment