When the session asks to ignore fragment mismatches, prerender throttling should ignore fragment-only differences too |
||||||
Issue descriptionWhen a client session sets that the URL fragment should be ignored for a navigation, the throttling and accounting in Custom Tabs should be consistent, and consider a URL launch with a different fragment as a success. Without that, a client consistently prerendering a URL and then launching it with a different fragment would be banned from prerendering.
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12f9b4ab77e708a5d8ad3a69161cab30cd484902 commit 12f9b4ab77e708a5d8ad3a69161cab30cd484902 Author: lizeb <lizeb@chromium.org> Date: Tue Mar 29 13:20:41 2016 customtabs: Don't always record non-matching fragments are prediction failures. When fragments are set to be ignored for URL matching for a given session, update the statistics (and the throttling) the same way. BUG= 597947 Review URL: https://codereview.chromium.org/1832063002 Cr-Commit-Position: refs/heads/master@{#383710} [modify] https://crrev.com/12f9b4ab77e708a5d8ad3a69161cab30cd484902/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java [modify] https://crrev.com/12f9b4ab77e708a5d8ad3a69161cab30cd484902/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
,
Mar 29 2016
,
Mar 29 2016
,
Mar 30 2016
Requesting a merge to M50. Reason: this is needed to avoid blacklisting clients prerendering w/ a different fragment (see https://bugs.chromium.org/p/chromium/issues/detail?id=574865 ).
,
Mar 30 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf4ffca5e31c5752d4468a99e4c843eed99d8b43 commit bf4ffca5e31c5752d4468a99e4c843eed99d8b43 Author: Benoit L <lizeb@chromium.org> Date: Wed Mar 30 12:34:08 2016 customtabs: Don't always record non-matching fragments are prediction failures. When fragments are set to be ignored for URL matching for a given session, update the statistics (and the throttling) the same way. BUG= 597947 Review URL: https://codereview.chromium.org/1832063002 Cr-Commit-Position: refs/heads/master@{#383710} (cherry picked from commit 12f9b4ab77e708a5d8ad3a69161cab30cd484902) Review URL: https://codereview.chromium.org/1839403002 . Cr-Commit-Position: refs/branch-heads/2661@{#430} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/bf4ffca5e31c5752d4468a99e4c843eed99d8b43/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java [modify] https://crrev.com/bf4ffca5e31c5752d4468a99e4c843eed99d8b43/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf4ffca5e31c5752d4468a99e4c843eed99d8b43 commit bf4ffca5e31c5752d4468a99e4c843eed99d8b43 Author: Benoit L <lizeb@chromium.org> Date: Wed Mar 30 12:34:08 2016 customtabs: Don't always record non-matching fragments are prediction failures. When fragments are set to be ignored for URL matching for a given session, update the statistics (and the throttling) the same way. BUG= 597947 Review URL: https://codereview.chromium.org/1832063002 Cr-Commit-Position: refs/heads/master@{#383710} (cherry picked from commit 12f9b4ab77e708a5d8ad3a69161cab30cd484902) Review URL: https://codereview.chromium.org/1839403002 . Cr-Commit-Position: refs/branch-heads/2661@{#430} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/bf4ffca5e31c5752d4468a99e4c843eed99d8b43/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java [modify] https://crrev.com/bf4ffca5e31c5752d4468a99e4c843eed99d8b43/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pasko@chromium.org
, Mar 25 2016