New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597925 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Consider get parameter to merge tree console.

Project Member Reported by olivierrobin@chromium.org, Mar 25 2016

Issue description

Tree console (https://build.chromium.org/p/chromium/console) has multiple modes (collapsed, uncollapsed, merged).
It appears that the current configuration is read from cookies (if there is a merged=true cookie, the view is merged).
The default mode is uncollapsed.

To have the tree displayed on kiosks, it would be helpful to be able to set the mode via get parameter (as kiosk often get only a URL).

I am not sure if the code is in Chromium, but I found this reference
https://src.chromium.org/svn/trunk/tools/aebuild/static/console.js?p=115967
and this
https://chromium.googlesource.com/chromium/tools/chromium-build/+/ac342a42f59a28e55b2df42f923e5fb306b3adb2/templates/base.html
 

Comment 1 by benhenry@google.com, Apr 27 2016

Components: Infra>Monitoring
Labels: -Infra-Monitoring
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/fcfbd836d6016cd2092784f54e7382bded8bfd96

commit fcfbd836d6016cd2092784f54e7382bded8bfd96
Author: olivierrobin@chromium.org <olivierrobin@chromium.org>
Date: Wed May 04 10:06:27 2016

Allow to override cookies in console waterfall with GET parameter.

Kiosk need to be configurable via URLs.

BUG= 597925 

Review-Url: https://codereview.chromium.org/1946633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300436 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/fcfbd836d6016cd2092784f54e7382bded8bfd96/masters/master.chromium/templates/console.html

Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87408

------------------------------------------------------------------
r87408 | olivierrobin@google.com | 2016-05-04T19:09:29.085933Z

-----------------------------------------------------------------
Owner: olivierrobin@chromium.org
Status: Started (was: Untriaged)
Assigning to olivierrobin@ - it appears you've been actively working on it. Thanks!
Status: Fixed (was: Started)
Hi

It is actually fixed.
You can set the merged and collapsed GET parameters to format your page.

Sign in to add a comment