New issue
Advanced search Search tips

Issue 597923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NetworkController can be closed too early in performance tests

Reported by gurr...@yandex-team.ru, Mar 25 2016

Issue description

If we have a benchmark that requires running a profile extender (for example, it has a BlankPageWithExtensionProfile page), the NetworkController will be closed when the profile extender calls TearDownBrowser(). And when later this benchmark starts running stories, it will try to call StartReplay method of NetworkController, which will fail, because the NetworkController is already closed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/636566857c10b4a4039de0656e5a289f6b775a04

commit 636566857c10b4a4039de0656e5a289f6b775a04
Author: gurrrik <gurrrik@yandex-team.ru>
Date: Mon Mar 28 10:25:33 2016

Do not close network controller in ProfileExtender if it was not opened there.

If we have a benchmark that requires running a profile extender (for example,
it has a BlankPageWithExtensionProfile page), the network_controller will be
closed when the profile extender calls TearDownBrowser(). And when later
this benchmark starts running stories, it will attempt to call StartReplay
method of network_controller, which will fail, because the network_controller
is already closed.
This CL fixes this behaviour by not closing network_controller inside the
profile extender if it was not opened in that profile extender.

The review https://codereview.chromium.org/1822083003/ adds is_open property
to NetworkController class. After it lands, I'll update this CL so that it
no longer requires protected member access.

BUG= 597923 

Review URL: https://codereview.chromium.org/1822043004

Cr-Commit-Position: refs/heads/master@{#383487}

[modify] https://crrev.com/636566857c10b4a4039de0656e5a289f6b775a04/tools/perf/profile_creators/profile_extender.py

Cc: dtapu...@chromium.org
Labels: Needs-Feedback
Can this issue now be marked as fixed?
Yes.
I wanted to mark it as fixed myself, but I could not find where I can do it.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 1 2016

Labels: -Needs-Feedback Needs-Review
Owner: dtapu...@chromium.org
Thank you for providing more feedback. Adding requester "dtapuska@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://sites.google.com/a/chromium.org/dev/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Unconfirmed)

Sign in to add a comment