New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597921 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Infobar arrow problems in MD

Project Member Reported by pkasting@chromium.org, Mar 25 2016

Issue description

The infobar arrow tip has the wrong Y coordinate.

It also has some kind of uninitialized-variable issue where it initially draws wider, then if you change tabs and change back, draws narrower.
 
The uninitialized variable issue is true pre-MD as well (which makes sense).
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a614eb3fe5fba327416aac6ee990bda0f4a6654f

commit a614eb3fe5fba327416aac6ee990bda0f4a6654f
Author: pkasting <pkasting@chromium.org>
Date: Fri Mar 25 21:58:33 2016

Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG= 597921 
TEST=On a brand new profile (so you get the "default browser" infobar on startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material Design mode.  The infobar arrow should not intersect the lock icon.

Review URL: https://codereview.chromium.org/1832023002

Cr-Commit-Position: refs/heads/master@{#383374}

[modify] https://crrev.com/a614eb3fe5fba327416aac6ee990bda0f4a6654f/chrome/browser/ui/views/location_bar/location_bar_view.cc

Labels: Merge-Request-50
This is a trivial patch, so requesting M-50 merge.

Comment 4 by tin...@google.com, Mar 26 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39df9e824ef7d9586232192a79100133778b876e

commit 39df9e824ef7d9586232192a79100133778b876e
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Mar 29 02:57:52 2016

Fix infobar arrow tip position on MD.

On non-MD, this moves the tip down by 1 px, which basically looks better for
HTTPS and not worse for other cases.

On MD, this moves the tip down by 2 px, which makes it look perfect on non-EV
HTTPS, kinda crappy on EV, and OK everywhere else.

More importantly, it makes the tip vertical position not depend on a horizontal
layout constant, which kinda made sense in non-MD (based on how the constants
were designed there) and makes no sense at all for MD.  This is important as I'm
about to change this constant's value in a way that would otherwise look awful
on MD.

Arguably, it might make sense to position the tip differently for all the
different icons, but hardcoding a bunch of different offsets like that makes my
hackles rise.

BUG= 597921 
TEST=On a brand new profile (so you get the "default browser" infobar on startup), set startup page to a non-EV HTTPS site.  Start Chrome in Material Design mode.  The infobar arrow should not intersect the lock icon.

Review URL: https://codereview.chromium.org/1832023002

Cr-Commit-Position: refs/heads/master@{#383374}
(cherry picked from commit a614eb3fe5fba327416aac6ee990bda0f4a6654f)

Review URL: https://codereview.chromium.org/1844453002 .

Cr-Commit-Position: refs/branch-heads/2661@{#416}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/39df9e824ef7d9586232192a79100133778b876e/chrome/browser/ui/views/location_bar/location_bar_view.cc

Status: Fixed (was: Started)
Fixed and merged.  Will open a new bug for the uninit-var problem.
Cc: tkonch...@chromium.org
Labels: TE-Verified-M50 TE-Verified-50.0.2661.57
Tested the issue on win8.1 chrome version 50.0.2661.57 with startup page "https://www.paypal.com" and #top-chrome-md="Material" - Infobar arrow doesn't intersect the lock icon - Fix works as expected

Please find the screenshot

597921.png
50.9 KB View Download
Labels: -Pri-3 OS-Chrome OS-Linux OS-Windows Pri-1
Cc: dhadd...@chromium.org
This should also be verified on Chrome OS M-50 beta channel.
Status: Verified (was: Fixed)

Sign in to add a comment