New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597913 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[Devtools] Unable to scroll the 'Styles' and 'Computed' tabs via mouse wheel on hovering the mouse over Scroll bar.

Project Member Reported by radhakri...@techmahindra.com, Mar 25 2016

Issue description

Chrome Version       : 51.0.2690.0 (Official Build)
OS Version : Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome and open Devtools on NTP
(2)Click on 'element.style' to add a style, a textbox with a cursor is seen.
(3)Now try to scroll the styles and computed tabs by hovering the mouse over the scrollbar via mouse wheel.

What is the expected result?
Should be able to scroll the tabs through mouse wheel.

What happens instead?
Unable to scroll the tabs through mouse wheel on hovering the mouse over scrollbar.

This is a regression issue broken in M-51

This issue is reproducible on Windows also. 

Note: Only when the focus is in the textbox to add the style rule, the issue is seen.

 
actual.mp4
1.8 MB Download
expected.mp4
1.6 MB Download
Labels: hasbisect
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build:51.0.2686.0
Bad Build :51.0.2687.0


CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/0b3847db495092eaeedf4b37b73f7784a3c12414..e233d14c7d5f89defc25a238157cdb58ca22e4d3

Suspecting https://codereview.chromium.org/1776843003 from changelog.

@dtapuska: Please re-assign if the issue is not related to your change.



Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/913f48327c7c50fa79df5af74d68fc7af7d3e2f4

commit 913f48327c7c50fa79df5af74d68fc7af7d3e2f4
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Mar 30 00:03:44 2016

Fix issue with hit testing on the layer tree.

When wheel event listeners were moved to the layer tree instead of
on individual layers in https://codereview.chromium.org/1639363002

We should have stopped hit testing on whether there was a wheel
event listener or not. These properties are checked on the general
page before processing the event.

BUG= 597913 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1843813002

Cr-Commit-Position: refs/heads/master@{#383872}

[modify] https://crrev.com/913f48327c7c50fa79df5af74d68fc7af7d3e2f4/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/913f48327c7c50fa79df5af74d68fc7af7d3e2f4/cc/trees/layer_tree_impl_unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/913f48327c7c50fa79df5af74d68fc7af7d3e2f4

commit 913f48327c7c50fa79df5af74d68fc7af7d3e2f4
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Mar 30 00:03:44 2016

Fix issue with hit testing on the layer tree.

When wheel event listeners were moved to the layer tree instead of
on individual layers in https://codereview.chromium.org/1639363002

We should have stopped hit testing on whether there was a wheel
event listener or not. These properties are checked on the general
page before processing the event.

BUG= 597913 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1843813002

Cr-Commit-Position: refs/heads/master@{#383872}

[modify] https://crrev.com/913f48327c7c50fa79df5af74d68fc7af7d3e2f4/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/913f48327c7c50fa79df5af74d68fc7af7d3e2f4/cc/trees/layer_tree_impl_unittest.cc

Labels: Hotlist-Input-Dev
Cc: tdres...@chromium.org rbyers@chromium.org
Labels: Merge-Request-50
This addresses  issue 598432 .

It did however uncover a previously existing issue in the compositor ( issue 599682 ) but that issue doesn't reproduce in M50 because the wheel_gestures feature isn't enabled in M50.

Requesting merge to M50; as this seems to break React JS sites and that is a big concern in that branch.

Comment 7 by tin...@google.com, Apr 5 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Please merge your change to M50 branch 2661 before 4:00 PM PST today if you like to make it to this week beta. We're cutting beta candidate today.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 5 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a65242bf4cadef0413ced54175c075532c2ef27

commit 8a65242bf4cadef0413ced54175c075532c2ef27
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Apr 05 18:07:15 2016

Fix issue with hit testing on the layer tree.

When wheel event listeners were moved to the layer tree instead of
on individual layers in https://codereview.chromium.org/1639363002

We should have stopped hit testing on whether there was a wheel
event listener or not. These properties are checked on the general
page before processing the event.

BUG= 597913 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1843813002

Cr-Commit-Position: refs/heads/master@{#383872}
(cherry picked from commit 913f48327c7c50fa79df5af74d68fc7af7d3e2f4)

Review URL: https://codereview.chromium.org/1864633002 .

Cr-Commit-Position: refs/branch-heads/2661@{#494}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/8a65242bf4cadef0413ced54175c075532c2ef27/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/8a65242bf4cadef0413ced54175c075532c2ef27/cc/trees/layer_tree_impl_unittest.cc

Cc: tkonch...@chromium.org
Labels: TE-Verified-M50 TE-Verified-50.0.2661.66
Tested the same on win8.1, mac 10.11 and Linux 14.04 chrome version 50.0.2661.66 - able to scroll the tabs through mouse wheel on hovering the mouse over scrollbar.

Fix works as expected

Please find the screencast
Recording #31.mp4
638 KB Download

Sign in to add a comment