This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

xhwang@, do you still need this bug? if not, can you resolve it as won't fix? thanks

TestMojoMediaClient was introduced when we don't have much test coverage on mojo media, so that we can use it to run mojo media manually.

mojo_pipeline_integration_test was also added to test mojo Media plus MojoRenderer, but as mojo evolves, that test has been disabled for long time.

Now mojo media has been shipped on multiple platforms, and we have many different types of tests covering it. Also, using the full fledge of pipeline integration tests to cover MojoRenderer seems a bit overkill. We should be able to just test it with unit tests.

Also, running TestMojoMediaClient (and RendererImpl) in the browser process has some weird issues, e.g. previously around AudioManager destruction crash.

With that, I feel we should just remove mojo_pipeline_integration_test. We should probably also remove ENABLE_TEST_MOJO_MEDIA_CLIENT. But we can leave TestMojoMediaClient to be used in the standalone media service, just in case we need it in the future.

To summarize, the plan is to:
1. remove ENABLE_TEST_MOJO_MEDIA_CLIENT build flag; I believe it not used by anyone given we are shipping mojo media on various platforms.
2. remove mojo_pipeline_integration_test, which caused a lot of complexity, and didn't provide as much test coverage on top of unittests.

dalecurtis/sandersd: WDYT?

I think it provided quite a lot of coverage on top of the unit tests, but certainly we don't need the full pipeline collection anymore. You might consider keeping a couple integration tests that don't rely on the original PIT, just PITBase. Up to you in any case.