New issue
Advanced search Search tips

Issue 597901 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

play/pause key from keyboard not working for Chrome OS media player

Project Member Reported by hychao@chromium.org, Mar 25 2016

Issue description

Connect logitech mk520r keyboard with Chromebook, hit media keys should control the built-in media player.
The next/prev track key works, but not the play/pause key.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fbc859e5011519563167b607b3f13515553e7c6

commit 7fbc859e5011519563167b607b3f13515553e7c6
Author: hychao <hychao@chromium.org>
Date: Wed Jul 13 03:44:37 2016

Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE

This change makes the media play/pause key on logitech keyboard
to send MEDIA_PLAY_PAUSE event, so it can control the built-in
media player on Chromebook.

BUG= 597901 
TEST=test with logitech mk520r keyboard

Review-Url: https://codereview.chromium.org/1835493003
Cr-Commit-Position: refs/heads/master@{#404976}

[modify] https://crrev.com/7fbc859e5011519563167b607b3f13515553e7c6/ui/events/keycodes/keyboard_code_conversion_xkb.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fbc859e5011519563167b607b3f13515553e7c6

commit 7fbc859e5011519563167b607b3f13515553e7c6
Author: hychao <hychao@chromium.org>
Date: Wed Jul 13 03:44:37 2016

Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE

This change makes the media play/pause key on logitech keyboard
to send MEDIA_PLAY_PAUSE event, so it can control the built-in
media player on Chromebook.

BUG= 597901 
TEST=test with logitech mk520r keyboard

Review-Url: https://codereview.chromium.org/1835493003
Cr-Commit-Position: refs/heads/master@{#404976}

[modify] https://crrev.com/7fbc859e5011519563167b607b3f13515553e7c6/ui/events/keycodes/keyboard_code_conversion_xkb.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment