Invalid JavaScript code for inline event handler should be compiled only once |
|||||||
Issue description1. Open http://w3c-test.org/html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-once.html Expected: The test passes. Actual: The test fails. It seems we try to compile invalid JavaScript code in body[onclick] every time when body.onclick is called.
,
Mar 25 2016
Or you can change console.log(errors) to console.log(errors === 1); The expected result should be - true true true The actual result - false false false
,
May 20 2016
,
May 20 2016
Relevant spec: https://html.spec.whatwg.org/multipage/webappapis.html#event-handler-content-attributes https://html.spec.whatwg.org/multipage/webappapis.html#internal-raw-uncompiled-handler Simple demo page: http://output.jsbin.com/vecoto Browsers tested: Chrome 52.0.2739.0 Linux: fail Firefox 46.0 Linux: pass Safari 9.1 Mac: fail Edge 13.10586 Win10: pass IE 11 Win10: pass
,
May 21 2016
,
Jul 25 2016
haraken@ thoughts?
,
Jul 26 2016
,
Jul 26 2016
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4 commit 2fb386fd03fc84f7ba3a72417bc2345ad6f308c4 Author: yukishiino <yukishiino@chromium.org> Date: Fri Jul 29 15:21:27 2016 binding: Compiles event handlers only once if not compilable. Blink no longer compiles a script for an event handler twice or more if the script is not compilable. BUG= 597900 Review-Url: https://codereview.chromium.org/2190553003 Cr-Commit-Position: refs/heads/master@{#408638} [modify] https://crrev.com/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-once-expected.txt [modify] https://crrev.com/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h [modify] https://crrev.com/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp [modify] https://crrev.com/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h
,
Aug 1 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by phistuck@gmail.com
, Mar 25 2016