New issue
Advanced search Search tips

Issue 597888 link

Starred by 0 users
Status: Duplicate
Merged: issue 621901
Owner:
gogerald@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 597889



Sign in to add a comment

bluetooth: windows: Call error callbacks upon object destruction.

Project Member Reported by scheib@chromium.org, Mar 25 2016 
Several classes retain callbacks while asynchronous operations are pending. In the event of the instances being destroyed the callbacks are not called, but they should be.

E.g.

BluetoothRemoteGattCharacteristicAndroid::
    ~BluetoothRemoteGattCharacteristicAndroid() {
...
  if (pending_start_notify_calls_.size()) {
    OnStartNotifySessionError(device::BluetoothGattService::GATT_ERROR_FAILED);
  }
}

Comment 2 by scheib@chromium.org, Mar 25 2016

Blocking: -490399 597889
Labels: -OS-Android -Pri-3 OS-Windows Pri-2
Owner: gogerald@chromium.org
Status: Assigned (was: Available)
Summary: bluetooth: windows: Call error callbacks upon object destruction. (was: bluetooth: android: Call error callbacks upon object destruction.)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08539daf0b416e5cebf3109119f4c9e6beb09d54

commit 08539daf0b416e5cebf3109119f4c9e6beb09d54
Author: gogerald <gogerald@chromium.org>
Date: Fri Apr 08 18:51:49 2016

Implement BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests.

This CL implements BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests.

It also fixes implicit cast between semantically different integer types issue.

In addition, it moves gatt_notify_characteristic_attempts_, gatt_write_characteristic_attempts_,
and gatt_read_characteristic_attempts_ check immediately after an operation in bluetooth_gatt_characteristic_unittest.cc
to after simulate operation since the operation is asynchronous down to the OS on Windows.

BUG=579202, 592843 , 427616 , 597888 

Review URL: https://codereview.chromium.org/1749403002

Cr-Commit-Position: refs/heads/master@{#386150}

[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/BUILD.gn
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth.gyp
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_device_win.cc
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_gatt_characteristic_unittest.cc
[add] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_gatt_notify_session_win.cc
[add] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_gatt_notify_session_win.h
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_low_energy_win.cc
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_low_energy_win.h
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_low_energy_win_fake.cc
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_low_energy_win_fake.h
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_remote_gatt_descriptor_win.h
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_remote_gatt_service_win.cc
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_task_manager_win.cc
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/bluetooth_task_manager_win.h
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/08539daf0b416e5cebf3109119f4c9e6beb09d54/device/bluetooth/test/bluetooth_test_win.h

Comment 4 by ortuno@chromium.org, Oct 6 2016

Mergedinto: 621901
Status: Duplicate (was: Assigned)
►

Sign in to add a comment