People specific spec https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-cards_people.png%3Fz=fit Sub-page spec https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_structure-subpage.png%3Fz=width
Setting default priority/type
Question for bettes@: I assume you would want to use a --paper-grey instead of the custom #5a5a5a color? The --paper-color-700 is #616161, which isn't super far off... Tommy
dschuyler talked to me: I guess we're using the --settings-side-nav-color exception here. Thanks!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c10ca235aa356649359a0eeafb66efa0c2409ea0 commit c10ca235aa356649359a0eeafb66efa0c2409ea0 Author: tommycli <tommycli@chromium.org> Date: Sat Mar 26 00:47:25 2016 Settings People Revamp: Address CSS wrongdoings. This also fixes the subheader of all subpages. BUG= 597868 Review URL: https://codereview.chromium.org/1832253002 Cr-Commit-Position: refs/heads/master@{#383423} [modify] https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0/chrome/browser/resources/settings/people_page/manage_profile.html [delete] https://crrev.com/bb7ae0e1760d0782437ac193214c944bc41790ff/chrome/browser/resources/settings/people_page/people_page.css [modify] https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0/chrome/browser/resources/settings/settings_page/settings_subheader.html [modify] https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/c10ca235aa356649359a0eeafb66efa0c2409ea0/chrome/browser/resources/settings/settings_shared_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f97a714079d2dc126c0d818f7593137ab3b62557 commit f97a714079d2dc126c0d818f7593137ab3b62557 Author: tommycli <tommycli@chromium.org> Date: Tue Apr 05 22:25:04 2016 Settings People Revamp: Fix Mange Profile empty name crash. Prevents sending an empty string name to C++. BUG= 597868 , 599842 Review URL: https://codereview.chromium.org/1857203003 Cr-Commit-Position: refs/heads/master@{#385305} [modify] https://crrev.com/f97a714079d2dc126c0d818f7593137ab3b62557/chrome/browser/resources/settings/people_page/manage_profile.html [modify] https://crrev.com/f97a714079d2dc126c0d818f7593137ab3b62557/chrome/browser/resources/settings/people_page/manage_profile.js
Custom #5a5a5a colors are only used in the side-nav. You should abide by these guidelines https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_color.png%3Fz=width
Appears to be to-spec now. Please reopen if it's not the case.
Comment 1 by bettes@chromium.org
, Mar 25 2016