New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597820 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

login_GaiaLogin failure

Project Member Reported by achuith@chromium.org, Mar 24 2016

Issue description

Stack:
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 457, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 343, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 372, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/login_GaiaLogin/login_GaiaLogin.py", line 30, in run_once
    password=self._password) as cr:
  File "/usr/local/autotest/common_lib/cros/chrome.py", line 121, in __init__
    self._browser = browser_to_create.Create(finder_options)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py", line 51, in Create
    self._credentials_path)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_with_oobe.py", line 14, in __init__
    backend, platform_backend, credentials_path)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 55, in __init__
    self._browser_backend.Start()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 137, in Start
    self.oobe.NavigateGaiaLogin(self._username, self._password)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 65, in NavigateGaiaLogin
    self._NavigateGaiaLogin(username, password, enterprise_enroll)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 82, in _NavigateGaiaLogin
    util.WaitFor(_GetGaiaFunction, 20)(self, username, password)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/core/util.py", line 86, in WaitFor
    res = condition()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 78, in _GetGaiaFunction
    elif self._GaiaIFrameContext() is not None:
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/oobe.py", line 25, in _GaiaIFrameContext
    gaia_iframe_context):
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 190, in EvaluateJavaScriptInContext
    expr, context_id=context_id, timeout=timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 35, in inner
    inspector_backend._ConvertExceptionFromInspectorWebsocket(e)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 32, in inner
    return func(inspector_backend, *args, **kwargs)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 203, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, context_id, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 45, in Evaluate
    res = self._inspector_websocket.SyncRequest(request, timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 110, in SyncRequest
    res = self._Receive(timeout)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 149, in _Receive
    data = self._socket.recv()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 596, in recv
    opcode, data = self.recv_data()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 606, in recv_data
    frame = self.recv_frame()
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 637, in recv_frame
    self._frame_header = self._recv_strict(2)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 746, in _recv_strict
    bytes = self._recv(shortage)
  File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/websocket-client/websocket.py", line 739, in _recv
    raise WebSocketConnectionClosedException()
DevtoolsTargetCrashException: Devtools target crashed

 
Cc: resetswitch@chromium.org
Cc: -achuith@chromium.org
Owner: achuith@chromium.org
Status: Assigned (was: Untriaged)
Labels: Hardware-Lab Performance-Power OS-Chrome
Do you have a link to the failing build?
I just tried it on TOT. This runs in the regression suite, but I haven't looked for it there.
iirc, I've seen something similar in the past; when I rebooted the device the failure would usually go away, and I never found a reliable repro besides sending a kill signal (Ctrl-C) to the autotest server, which seemed to sometimes introduce it.
Labels: -Pri-2 Pri-1
Cc: kozyatinskiy@chromium.org dgozman@chromium.org pfeldman@chromium.org
Status: Started (was: Assigned)
Bisect reveals that this change broke it: 
https://codereview.chromium.org/1812983002
@achuith, could you provide a link to instruction how to run this test with ToT for debugging?
I've uploaded fix for one problem: https://codereview.chromium.org/1863363003/.
Alexey: Let me take a look at your fix - I'll let you know if it worked.

The current repo involves the simple chrome for chromeos flow and running tests on a chromeos device. I'm going to see if I can find a simpler illustration of the failing case.

Thank you for your prompt attention to this!
There is a renderer crash in  issue 601285 , may be related.
@achuith, could you try with https://codereview.chromium.org/1867903002/ please? It was landed 13 minutes ago.
Cc: abodenha@chromium.org kkan...@chromium.org achuith@chromium.org dtosic@chromium.org
 Issue 601285  has been merged into this issue.
Cc: harpreet@chromium.org
Status: Fixed (was: Started)
Yup, https://codereview.chromium.org/1867903002/ fixes it.
We should look into adding a browser test (or perhaps some other kind of test) to prevent this regression.
Thank you.
I've added layout test, this test runs on try bot for prevent this regression in future.
I'm adding more tests in https://codereview.chromium.org/1873533002/.
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dade0c6aaa5902990bd653c0239fbf855a7cb2e0

commit dade0c6aaa5902990bd653c0239fbf855a7cb2e0
Author: dgozman <dgozman@chromium.org>
Date: Fri Apr 08 03:05:22 2016

[DevTools] Force context creation when runtime is enabled.

BUG= 597820 , 601144 

Review URL: https://codereview.chromium.org/1873533002

Cr-Commit-Position: refs/heads/master@{#385960}

[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
[modify] https://crrev.com/dade0c6aaa5902990bd653c0239fbf855a7cb2e0/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

Cc: mzheng@chromium.org feiling@chromium.org
Labels: VerifyIn-51
In M51-Dev 8172.1.0 (test image), login_GaiaLogin gives error:
FAIL: Unhandled AttributeError: 'CrosBrowserOptions' object has no attribute 'extensions_to_load'

Seeing this on wolf.
Status: Started (was: Fixed)
Labels: -Hardware-Lab
Cc: eakuefner@chromium.org
Regarding Comment #23 looks related to the following CL
https://codereview.chromium.org/1874473006


Status: Fixed (was: Started)
Tracking the CrosBrowserOptions' object has no attribute 'extensions_to_load' issue in separate bug crbug.com/604134
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment