New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597796 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Mar 2016
Cc:
█ phajdan.jr@chromium.org
dpranke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ios_rel_device_gn compile step ran for views specific change

Project Member Reported by tfarina@chromium.org, Mar 24 2016 
While ios_rel_device_ninja (which is using gyp) has skipped (rightly)
the compile step.

Example in this CL -> https://codereview.chromium.org/1828363002/

Comment 1 by dpranke@chromium.org, Mar 24 2016 

You changed a BUILD.gn file; any change to a BUILD.gn file will cause analyze to bail out and try to build everything, because it can't tell how the build graph was actually affected.

I would guess that the equivalent gyp file didn't actually get loaded (because the analyze logic in gyp is actually implemented inside gyp, not outside like in GN) and so GYP was able to do something smarter.

Comment 2 by tfarina@chromium.org, Mar 24 2016 

If it is working as intended feel free to close so. :)

Comment 3 by dpranke@chromium.org, Mar 24 2016

Status: WontFix (was: Untriaged)
It's at least working as expected :). Ideally we'd make the GN implementation of analyze smarter at some point.
►

Sign in to add a comment