Turn on TEXTURE_CUBE_MAP_SEAMLESS on desktop GL for ES3 |
||||||
Issue descriptionBy default it is off, and for ES3 it is required to be on all the time. This is the reason the deqp/texturefiltering_cub_* tests failing
,
Mar 24 2016
Awesome find.
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39a22dc8028987efa3ca24135922841d2d2d387c commit 39a22dc8028987efa3ca24135922841d2d2d387c Author: zmo <zmo@chromium.org> Date: Fri Mar 25 21:23:37 2016 Turn on seamless cubemap by default on Desktop GL for ES3. BUG= 597794 TEST=deqp/texturefiltering_cube_* R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1831833006 Cr-Commit-Position: refs/heads/master@{#383362} [modify] https://crrev.com/39a22dc8028987efa3ca24135922841d2d2d387c/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/39a22dc8028987efa3ca24135922841d2d2d387c/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
,
Mar 25 2016
,
Mar 25 2016
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e22e7e8fe94d4f4deadcb2d6460e6a1ca38cd35 commit 0e22e7e8fe94d4f4deadcb2d6460e6a1ca38cd35 Author: zmo <zmo@chromium.org> Date: Fri Mar 25 23:34:43 2016 Revert of Turn on seamless cubemap by default on Desktop GL for ES3. (patchset #3 id:40001 of https://codereview.chromium.org/1831833006/ ) Reason for revert: This doesn't work on Mac Intel (most likely a driver bug) Original issue's description: > Turn on seamless cubemap by default on Desktop GL for ES3. > > BUG= 597794 > TEST=deqp/texturefiltering_cube_* > R=piman@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/39a22dc8028987efa3ca24135922841d2d2d387c > Cr-Commit-Position: refs/heads/master@{#383362} TBR=piman@chromium.org,piman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 597794 Review URL: https://codereview.chromium.org/1840553002 Cr-Commit-Position: refs/heads/master@{#383405} [modify] https://crrev.com/0e22e7e8fe94d4f4deadcb2d6460e6a1ca38cd35/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/0e22e7e8fe94d4f4deadcb2d6460e6a1ca38cd35/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
,
Mar 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da412cef54b24fb6013f6ec5ad89327bf1151b80 commit da412cef54b24fb6013f6ec5ad89327bf1151b80 Author: zmo <zmo@chromium.org> Date: Mon Mar 28 23:54:20 2016 Turn on seamless cubemap by default on Desktop GL for ES3. BUG= 597794 TEST=deqp/texturefiltering_cube_* R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1840743004 Cr-Commit-Position: refs/heads/master@{#383615} [modify] https://crrev.com/da412cef54b24fb6013f6ec5ad89327bf1151b80/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/da412cef54b24fb6013f6ec5ad89327bf1151b80/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/da412cef54b24fb6013f6ec5ad89327bf1151b80/gpu/config/gpu_driver_bug_list_json.cc [modify] https://crrev.com/da412cef54b24fb6013f6ec5ad89327bf1151b80/gpu/config/gpu_driver_bug_workaround_type.h
,
Jun 17 2016
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60714ca531b4b2f90ceed1a69ec44e0847998694 commit 60714ca531b4b2f90ceed1a69ec44e0847998694 Author: zmo <zmo@chromium.org> Date: Wed Jun 22 18:09:28 2016 The disable_seamless_cube_map workaround should only apply to primary Intel. On Mac retina where Intel is integrated and AMD/NVIDIA is discrete and is what is used for WebGL, this workaround should not apply. (This only affects WebGL2 on mac, so skip general try/cq bots) BUG= 606074 , 597794 TEST=mac gpu bots R=bajones@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2081813002 Cr-Commit-Position: refs/heads/master@{#401344} [modify] https://crrev.com/60714ca531b4b2f90ceed1a69ec44e0847998694/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/60714ca531b4b2f90ceed1a69ec44e0847998694/gpu/config/gpu_driver_bug_list_json.cc
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0cf15e974aff5aaf53df87079969f181948a099 commit d0cf15e974aff5aaf53df87079969f181948a099 Author: zmo <zmo@chromium.org> Date: Thu Jun 30 21:27:12 2016 Enable seamless cubemap on Mac Intel. BUG= 597794 , 606074 NOTRY=true TEST=eanbled webgl2 conformance tests CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2113573002 Cr-Commit-Position: refs/heads/master@{#403294} [modify] https://crrev.com/d0cf15e974aff5aaf53df87079969f181948a099/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/d0cf15e974aff5aaf53df87079969f181948a099/gpu/config/gpu_driver_bug_list_json.cc
,
Aug 4 2016
,
Jun 20 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by zmo@chromium.org
, Mar 24 2016