New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597793 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Resolution change video stopped playing after seeking

Project Member Reported by avkodipelli@chromium.org, Mar 24 2016

Issue description

Chrome Version: 50.0.2661.50 
Chrome OS Version: 7978.29.0
Chrome OS Platform: jerry
Network info: Wifi

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Start playing below resolution video
http://storage.googleapis.com/chromiumos-test-assets-public/Shaka-Dash/switch_1080p_720p.mp4

(2) Seek video to different positions
(3) Observe video playback

Expected Result:
Video play smoothly after seek

Actual Result:
Video stopped playing after few forward and backward seeking

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.
Not reproduced after disabling the hardware decode.

 
avkodipelli@ Can you also check M51 (tot) and M49? Thanks.
Labels: VideoShortList
Thanks for the report. Do we have any estimation of the regression range?
This issue is reproduced on 8104.0.0/51.0.2688.0.

Comment 6 by mu...@chromium.org, Mar 25 2016

avkodipelli@ Let's also check 49 to see how long this failure has been around.
avkodipelli@ please share your results on 49.
mussa@/wuchengli@ can we confirm this is the CL that may have caused this regression?
https://codereview.chromium.org/1643123003/
Owner: posciak@chromium.org
Status: Assigned (was: Untriaged)
posciak@ would you be the right owner for this issue? Please reassign as necessary. This is currently a stable blocker.
Unable to reproduce this issue on 49.0.2623.95/7834.60.0 on jerry device.
Cc: marc...@chromium.org
marcheu@ Who should own this bug? Can you please suggest a name so we can make progress on this stable blocker?
Yes Pawel is the right owner for video bugs.
Thanks marcheu@. posciak@ Can you please update this bug with your investigation?
Status: Started (was: Assigned)
After a number of seeks with reallocations we are failing to allocate the required number of pictures and AssignPictureBuffers() fails. Still investigating why exactly this could be happening.
After more investigation, I can confirm we are hitting a corner case in the resolution change sequence in V4L2SVDA. I am working on a fix.

Reverting https://codereview.chromium.org/1643123003/ from M50 would also fix this issue and we can do this safely as well. That could perhaps be the best solution for M50.
posciak@ can you please submit the revert as you suggest?
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb7bf3fc301c41f06145551aed91cc344fb08d9e

commit bb7bf3fc301c41f06145551aed91cc344fb08d9e
Author: posciak <posciak@chromium.org>
Date: Fri Apr 08 03:11:28 2016

Revert "V4L2SVDA: Move allocation from GPU Child thread to decoder thread."

This reverts https://codereview.chromium.org/1643123003/. Please see
 crbug.com/597793  for details.

BUG= 597793 
TEST=vdatest,crosvideo.appspot

Review URL: https://codereview.chromium.org/1863523003

Cr-Commit-Position: refs/heads/master@{#385969}

[modify] https://crrev.com/bb7bf3fc301c41f06145551aed91cc344fb08d9e/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/bb7bf3fc301c41f06145551aed91cc344fb08d9e/content/common/gpu/media/v4l2_slice_video_decode_accelerator.h

Labels: Merge-Request-50
Labels: -Merge-Request-50 Merge-Approved-50
Approving merge to M50.
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 11 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20276b71163463a4337979fea163ab97e8f01611

commit 20276b71163463a4337979fea163ab97e8f01611
Author: Pawel Osciak <posciak@chromium.org>
Date: Mon Apr 11 07:54:07 2016

Revert "V4L2SVDA: Move allocation from GPU Child thread to decoder thread."

This reverts https://codereview.chromium.org/1643123003/. Please see
 crbug.com/597793  for details.

BUG= 597793 
TEST=vdatest,crosvideo.appspot

Review URL: https://codereview.chromium.org/1863523003

Cr-Commit-Position: refs/heads/master@{#385969}
(cherry picked from commit bb7bf3fc301c41f06145551aed91cc344fb08d9e)

Review URL: https://codereview.chromium.org/1875983002 .

Cr-Commit-Position: refs/branch-heads/2661@{#546}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/20276b71163463a4337979fea163ab97e8f01611/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/20276b71163463a4337979fea163ab97e8f01611/content/common/gpu/media/v4l2_slice_video_decode_accelerator.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified 7978.62.0 / 50.0.2661.87

Sign in to add a comment