New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597767 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use "bitmaprenderer" as type string corresponding to ImageBitmapRenderingContext

Project Member Reported by junov@chromium.org, Mar 24 2016

Issue description

The current implementation uses "imagebitmap".
Docs published by mozilla use "bitmaprenderer":
https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmapRenderingContext

Let's follow that.
 

Comment 1 by junov@chromium.org, Mar 24 2016

Components: Blink>Canvas
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d30be906486920495089f6e63f2ea8c1869726f

commit 3d30be906486920495089f6e63f2ea8c1869726f
Author: junov <junov@chromium.org>
Date: Tue Mar 29 18:48:19 2016

Change the context type name to "bitmaprender" for ImageBitmapRenderingContext

Previously, we used "imagebitmap". Firefox uses "bitmaprenderer". This
changes makes the two interoperable.  This will be relfected in the
spec which is WIP.

BUG= 597767 

Review URL: https://codereview.chromium.org/1826383002

Cr-Commit-Position: refs/heads/master@{#383781}

[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-clearRect-in-worker.html
[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker.html
[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-paths-in-worker.html
[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-strokeRect-in-worker.html
[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap-alpha.html
[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap-no-alpha.html
[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferImageBitmap.html
[modify] https://crrev.com/3d30be906486920495089f6e63f2ea8c1869726f/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

Comment 3 by junov@chromium.org, Apr 4 2016

Status: Fixed (was: Assigned)

Sign in to add a comment