New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597757 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Material design ripple effects on toolbar buttons are clipped by the bookmarks bar

Project Member Reported by tdander...@chromium.org, Mar 24 2016

Issue description

The bottom edge of the ripple animation on the toolbar navigation buttons (back, forward, reload) is clipped by the top edge of the bookmarks bar.

This is a recent regression in M-51.

 
Evan, could this be related to your recent changes to the bookmarks bar?

https://chromiumcodereview.appspot.com/1820793003/
and
https://chromiumcodereview.appspot.com/1823623003/

If nothing jumps out as the cause I can perform a bisect.
Labels: -M-51 M-50
Owner: est...@chromium.org
Status: Assigned (was: Available)
This is actually happening on Chrome OS 50.0.2661.50 beta branch, my guess is that it would be from a recent merge by estade@. Evan do you know the root cause of this? If not please let me know and I will do some digging.

Comment 4 by est...@chromium.org, Mar 29 2016

Yes I bet it's related to the change that made the bookmark bar paint to a layer, but I'm not sure what to do about it. We need to somehow tell ripple layers to have a higher z order (not just relative to their sibling layers, but also to cousin layers).
Owner: bruthig@chromium.org
Status: Started (was: Assigned)
tehmaxhypegaming@, sorry I missed your comment (#2).  Issue 596122  is unrelated to this one.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52ef1ab0da46ea871271a0a2a6fa0ced541b0381

commit 52ef1ab0da46ea871271a0a2a6fa0ced541b0381
Author: bruthig <bruthig@chromium.org>
Date: Sat Apr 02 13:57:38 2016

The Material Design ink drops on the ToolbarView are supposed to expand beyond the bounds of the ToolbarView and should be visible above the BookmarkBarView.

BUG= 597757 
TEST=Manual

Review URL: https://codereview.chromium.org/1849563002

Cr-Commit-Position: refs/heads/master@{#384808}

[modify] https://crrev.com/52ef1ab0da46ea871271a0a2a6fa0ced541b0381/chrome/browser/ui/views/frame/browser_view.cc

Status: Fixed (was: Started)
Labels: Merge-Request-50

Comment 12 by tin...@google.com, Apr 3 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Please merge your change to M50 branch 2661 by 5:00 PM on Monday, 04/04/16 so we can take it for next week beta. Thank you.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 4 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3a6d1ef7c91fd4fce9e3a171739e8134996e524

commit c3a6d1ef7c91fd4fce9e3a171739e8134996e524
Author: Ben Ruthig <bruthig@chromium.org>
Date: Mon Apr 04 15:16:19 2016

The Material Design ink drops on the ToolbarView are supposed to expand beyond the bounds of the ToolbarView and should be visible above the BookmarkBarView.

BUG= 597757 
TEST=Manual

Review URL: https://codereview.chromium.org/1849563002

Cr-Commit-Position: refs/heads/master@{#384808}
(cherry picked from commit 52ef1ab0da46ea871271a0a2a6fa0ced541b0381)

Review URL: https://codereview.chromium.org/1853173002 .

Cr-Commit-Position: refs/branch-heads/2661@{#472}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/c3a6d1ef7c91fd4fce9e3a171739e8134996e524/chrome/browser/ui/views/frame/browser_view.cc

Labels: TE-Verified-M51 TE-Verified-51.0.2700.0
Tested the same on win8.1 and Linux 14.04 chrome version 51.0.2700.0 by enabling #top-chrome-md flag to "material" in chrome://flags - observed no clipping of navigation buttons with the bookmark bar.

Please find the screenshot
597757.png
13.4 KB View Download
Labels: TE-Verified-M50 TE-Verified-50.0.2661.66
Verified the issue on Win 7 and Ubuntu 14.04 and its working fine.
Attached the screen shot for the reference.Hence added the TE-Verified labels.
597757_April_6.png
51.2 KB View Download

Comment 17 Deleted

Comment 18 Deleted

Labels: TE-Verified-51.0.2704.22
Verified the issue on Win 7 and Ubuntu 14.04 using 51.0.2704.22 and its working fine.Attached a screen cast for the same.
597757_April_21.mp4
867 KB Download
Status: Verified (was: Fixed)
Verified on 50.0.2661.103/7878.74.0 Chrome OS

Sign in to add a comment