New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597741 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CustomTabActivityTest#testPrecreatedRenderer flaking

Reported by kra...@amazon.com, Mar 24 2016

Issue description

Chrome Version       : Any (e.g. tip of master)
OS: Android

What steps will reproduce the problem?
Run CustomTabActivityTest#testPrecreatedRenderer several times.
What is the expected result?
100% of test runs should succeed
C   20.267s Main  ********************************************************************************
C   20.267s Main  [==========] 1 test ran.
C   20.267s Main  [  PASSED  ] 1 test.
C   20.267s Main  ********************************************************************************

What happens instead?
13 out of 169 tests failed in a sample test run with num_retries=0.
C   18.544s Main  ********************************************************************************
C   18.544s Main  Detailed Logs
C   18.544s Main  ********************************************************************************
C   18.544s Main  [FAIL] org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testPrecreatedRenderer:
C   18.544s Main  junit.framework.AssertionFailedError
C   18.544s Main  	at org.chromium.chrome.browser.customtabs.CustomTabActivityTest.testPrecreatedRenderer(CustomTabActivityTest.java:708)
C   18.544s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C   18.544s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C   18.544s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C   18.544s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C   18.544s Main  	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:802)
C   18.544s Main  	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C   18.544s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C   18.544s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   18.545s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   18.545s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:556)
C   18.545s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1705)
C   18.545s Main  ********************************************************************************
C   18.545s Main  Summary
C   18.545s Main  ********************************************************************************
C   18.545s Main  [==========] 1 test ran.
C   18.545s Main  [  PASSED  ] 0 tests.
C   18.545s Main  [  FAILED  ] 1 test, listed below:
C   18.545s Main  [  FAILED  ] org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testPrecreatedRenderer
C   18.545s Main
C   18.545s Main  1 FAILED TEST
C   18.545s Main  ********************************************************************************

Please provide any additional information below. Attach a screenshot if
possible.
This might be related to crbug 530225.
I don't have access to the bug, but it disabled the test for low end devices stating that they fail on Svelte
--> Fixing this bug might also fix the test for Svelte devices (someone with access to that bug might be able to verify if it is the same stack trace)

 

Comment 2 by pasko@chromium.org, Mar 25 2016

Issue 530225 has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c94be22307df94b2da87ce920880ada92c28efe

commit 4c94be22307df94b2da87ce920880ada92c28efe
Author: kraush <kraush@amazon.com>
Date: Fri Mar 25 22:28:41 2016

Eliminate race condition in CustomTabActivityTest

Eliminates a race condition in CustomTabActivityTest#testPrecreatedRenderer
by waiting for the new custom tab to open before asserting

BUG= 597741 

Review URL: https://codereview.chromium.org/1834783002

Cr-Commit-Position: refs/heads/master@{#383385}

[modify] https://crrev.com/4c94be22307df94b2da87ce920880ada92c28efe/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Comment 4 by pasko@chromium.org, Mar 29 2016

Owner: kra...@amazon.com
Status: Fixed (was: Untriaged)

Sign in to add a comment