New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597717 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
dbeam@chromium.org
tbuck...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 425627



Sign in to add a comment

Text for Advanced Font Settings installed

Project Member Reported by dschuyler@chromium.org, Mar 24 2016 
In the mocks at
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Appearance-web-content.png%3Fz=width&c=show

We have a sub-label for the Advanced Font Settings
extension when it's not installed.  How about a
different sub-label for when the extension is
installed?  Maybe it could say "Open extension options".
There is a screen shot attached.

Clicking the Advanced Font Settings would open
the options for the extension, like it does in the
current settings (options).

WDYT, would you like a different message?
Screenshot from 2016-03-24 11:48:19.png
4.6 KB View Download

Comment 1 by dschuyler@chromium.org, Mar 24 2016 

In case it helps, here's more description of the behavior:
clicking Advanced font settings without the extension installed will open a new tab showing the Extension in the web store. If it is installed, that is automatically detected and the Advanced font settings with the extension installed will open a new tab showing the options page for the extension.

Comment 2 by bettes@chromium.org, Mar 25 2016

Owner: dschuyler@chromium.org
SGTM!

Comment 3 by bettes@chromium.org, Mar 25 2016

Labels: Proj
Dave, please label future bugs with Proj-MaterialDesign-WebUI. Thanks!

Comment 4 Deleted

Comment 5 Deleted

Comment 6 by dschuyler@chromium.org, Mar 25 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aebfe150743842f343a0887972960597c6ab3b2

commit 9aebfe150743842f343a0887972960597c6ab3b2
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Apr 12 18:18:43 2016

[MD settings] advanced font settings extension link

This CL changes the advanced font settings setting to
either open the extension for installation or open
the extension options, depending on whether the
extension is currently installed.

BUG= 597717 ,  531786 

Review URL: https://codereview.chromium.org/1877923002

Cr-Commit-Position: refs/heads/master@{#386740}

[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/app/settings_strings.grdp
[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp
[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.js
[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/browser/ui/webui/settings/font_handler.cc
[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/browser/ui/webui/settings/font_handler.h
[modify] https://crrev.com/9aebfe150743842f343a0887972960597c6ab3b2/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 8 by dschuyler@chromium.org, Apr 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment