New issue
Advanced search Search tips

Issue 597699 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Sheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago

Project Member Reported by rsleevi@chromium.org, Mar 24 2016

Issue description

Sheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago.


Add Bug number which got updated:
https://bugs.chromium.org/p/chromium/issues/detail?id=596501#c5

Issue/Concern or feedback:
I thought that this rule was meant to be every 7 days, but it happened within a day. The user didn't give feedback, just acknowledged that they would be providing feedback.

One challenge with this is trying to restore the proper labels and owners - "undoing" this change requires going through the bug history and trying to figure out the previous status/owner.

Two actionable items from this:
- Was this meant to wait 7 days from setting the Needs-Feedback before setting Needs-Review?
- Is the expectation that bug editors will use a common triage status (e.g. all such bugs go back Unconfirmed, reset the Owner), or is the expectation that bug editors will restore the status to "before" what the bot did - the same status/owner, for example? If the latter, it'd be useful to include whatever fields SheriffBot changed and their old values (or an 'undo change' in Monorail), but I suspect it'd be more useful for team health with the former, which would mean making sure we document somewhere the 'right' way to work in concert with SheriffBot to make great progress.
 
As soon as the bot saw feedback from the original author of the issue, that fell after the Needs-Feedback label was applied, it popped it into a Needs-Review state.


Note, there is a separate N day rule, but the usage is different.  If there is no response for N days, then it will close out the issue.
Status: Fixed (was: Assigned)
We made few changes to this rule and the current behavior is as below.
1. We run this on daily basis.
2. If feedback is received then we add "Needs-Review" label and remove "Needs-Feedback"
3. No status changed.
4. Owners will be added if None is present or the Owner is reporter of the bug.

IF no feedback:
We wait for 30 days and archive the bug with message.

Please re-open and give us your feedback if you disagree. Thanks



Sounds great, thanks!

Sign in to add a comment